Fixed a bug where the next button would loop through textfields #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where the next button would loop through textfields if they had the same y position but inside different subviews. De-complicated some functions.
…instead of self.bounds which was causes the scroll view to not take into consideration the y position of the scrollview when figuring out how to set the insets. Though its still not completely fixed because I believe it needs to take into account the y value relative to the top of the screen, but I don't know for sure yet.
|
Hi - sorry about the delay, just looking through some of these pull requests. This one's a bit huge; would you mind splitting it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the next button would loop through textfields if they had the same y position, but inside different subviews.
De-complicated some functions.
Made some formatting consistent.