Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a fixed-width font for less jank #86

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

karbassi
Copy link
Collaborator

@karbassi karbassi commented Jul 8, 2020

  • Change to monospacedDigitSystemFont
  • Remove old version checks
  • Update build target to 10.11, as set by the project

Fixes #85

- Change to monospacedDigitSystemFont
- Remove old version checks
- Update build target to 10.11, as set by the project

Fixes michaelvillar#85
@robinstewart
Copy link
Contributor

Can you post a few screenshots?

@karbassi
Copy link
Collaborator Author

karbassi commented Jul 8, 2020

See if you can spot which one is the before and which is after.

before after

right one is after

@karbassi
Copy link
Collaborator Author

karbassi commented Jul 8, 2020

@robinstewart @michaelvillar Shall I merge?

@robinstewart
Copy link
Contributor

Does this also affect the red time text? If so can you post what it looks like unpaused or at zero remaining seconds?

@nvenegas
Copy link

nvenegas commented Jul 8, 2020

@karbassi thanks for doing this!

@robinstewart it doesn't affect the red text (9:19am is the current release, 9:24 is a build from this branch)

current-release monospace

@karbassi karbassi merged commit 2a48750 into michaelvillar:master Jul 9, 2020
@karbassi karbassi deleted the karbassi/issue85 branch July 9, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a fixed-width font and leading zeros for less jank
3 participants