Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(en.json): add alias for korea following ISO 3166/MA #312

Merged

Conversation

maxkre96
Copy link
Contributor

@maxkre96 maxkre96 commented Nov 15, 2022

Currently, the country name for south korea does not include ISO 3166/MA for the english version.
I added these along with two simple tests.

Since I did not change the official name and just added aliases this PR should not break any existing functionality

@maxkre96 maxkre96 changed the title feat(en.json): add alias for korea following SO 3166/MA feat(en.json): add alias for korea following ISO 3166/MA Nov 15, 2022
@maxkre96 maxkre96 force-pushed the feature/add-south-korea-alias branch from 9032b32 to 0c6c95d Compare November 15, 2022 11:35
@michaelwittig michaelwittig merged commit 8146716 into michaelwittig:master Apr 12, 2023
@michaelwittig
Copy link
Owner

closes #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants