Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias for South Korea #313

Closed
maxkre96 opened this issue Nov 15, 2022 · 1 comment
Closed

Alias for South Korea #313

maxkre96 opened this issue Nov 15, 2022 · 1 comment

Comments

@maxkre96
Copy link
Contributor

Currently, in version 7.0 the english name of south korea following ISO 3166/MA is not accepted by the package.

Current Behavior:
i18nIsoCountries.getAlpha2Code("Korea, Republic of") -> undefined
i18nIsoCountries.getAlpha2Code("Republic of Korea") -> undefined
i18nIsoCountries.getAlpha2Code("South Korea") -> KR

Expected Behavior:
i18nIsoCountries.getAlpha2Code("Korea, Republic of") -> KR
i18nIsoCountries.getAlpha2Code("Republic of Korea") -> KR
i18nIsoCountries.getAlpha2Code("South Korea") -> KR

A Pull Request to add the alias has been proposed
@michaelwittig michaelwittig mentioned this issue May 12, 2023
Merged
@michaelwittig
Copy link
Owner

closed by #312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelwittig @maxkre96