-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Politicians with $0 DEM don't show up in search #67
Comments
i've changed the way the graphs are built to include legislators with $0. There's three different methods I've found to do this: Obviously, there's tweaking that could/should be done on both methods 1 and 2, but does anyone have a preference? One minor hidden drawback to 2 is that the graph files are bigger due to all the extra edges. |
I like option 1 -- except that when you click on that "dummy company called Accepted $0", what comes up is (not surprisingly) a bit confusing. Option 2 looks a bit "unrefined" in the graph to me, but could also work. |
Yeah - consider these prototypes for now - they both need some work to On 09/25/2013 09:55 AM, dturnbull wrote:
|
I like Option 2. They look like a posse and it avoids the dummy company problem (what do we call that?). With some styling, it would look great. How much bigger are the graphs? Just a couple K? |
ok - I went with option two. I believe I've polished things enough to be usable - I've removed the box, and slightly faded the people with no contribs. |
Users currently won't know that if someone isn't showing up in the search it is because they have $0 DEM. They might think it is because we are missing their data or something is wrong/not working. It'd be good for all legislators to be included, even those that have $0 in DEM to avoid this confusion.
The text was updated successfully, but these errors were encountered: