Fixed canvas scrolling and size ratio #96
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
closes #56
closes #88
Summary of changes
initialBounds
tounitBounds
canvasSizeToBounds
to scale theunitBounds
such that Canvas display ratio #88 is satisfiedcanvas
instead of thedocument
. Scroll zooming will now only work when the mouse is over the canvas.findElementById
intoComponents.Common.HTML
as it is a common function.findElementById
so that it will throw an error if the element is not found instead of failing silentlyonResize
toresize
inComponents.Canvas.Controller
Scroll
action fromComponents.Main
Tests