Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes dependencies in ESM build #423

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

sntran
Copy link

@sntran sntran commented Nov 14, 2018

Related Issue

#422

Your solution

Removed external option for Rollup and added resolve and commonjs plugins.

How Has This Been Tested?

Used the new ESM bundle on the browser as a module, and AOS is working. As it does not change any source code, it should work fine as is.

<script type="module">
  import AOS from "./node_modules/aos/dist/aos.esm.js";
  AOS.init({});
</script>

@bavarianbytes
Copy link

Is this project dead? Would need that too. Want to use AOS as native ESM module. Therefore deps should be included in the ESM version of AOS.

@egidiusmengelberg
Copy link

Yeah I need this too. I'm using this library with Nuxt 3 and keep having issues with imports. egidiusmengelberg/nuxt-aos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants