Overview layout sizes fixes #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression in previous changes. Closes: micheleg#1836
This was
linked to
issues
Oct 9, 2022
3v1n0
force-pushed
the
overview-layout-fixes
branch
from
c30d968
to
2d7ceb9
Compare
This was referenced Oct 9, 2022
Fixes a bug causing the dock to be hidden when closing a menu while overview was visible (with autohide enabled). LP: #1983130
We should not always hide the menus depending on the mouse position, but this depends on the current user configurations. LP: #1983130 Closes: micheleg#1769
We now need to also adapt the app-grid area to the available space in order to correctly allocate the left/right buttons in autohide mode.
For some reason we need to use an even value, this is probably due to the fact that such value is going to be proportional to the available space. Closes: micheleg#1612 LP: #1979096
When resizing the overview controls layout to adapt it to the dock size we also need to take care of reducing the vertical size accordingly, otherwise we may end up in cases in which we don't have space to show multiple workspaces when in the window-picker mode.
3v1n0
force-pushed
the
overview-layout-fixes
branch
from
2d7ceb9
to
b965fcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.