Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling dash-to-dock messes up search results navigation #1612

Closed
yoursred opened this issue Dec 7, 2021 · 25 comments · Fixed by #1849 or #2020
Closed

Enabling dash-to-dock messes up search results navigation #1612

yoursred opened this issue Dec 7, 2021 · 25 comments · Fixed by #1849 or #2020

Comments

@yoursred
Copy link

yoursred commented Dec 7, 2021

GNOME: 41.1
dash-to-dock: 71
Kernel: 5.14.21-2-MANJAR

Description: With dash-to-dock enabled, side-to-side navigation with the arrow keys is nonfunctional, and trying to navigate takes the search bar out of focus.

@yoursred
Copy link
Author

yoursred commented Dec 7, 2021

Update: intelligent autohide seems to be cause

@yoursred
Copy link
Author

yoursred commented Dec 7, 2021

Update: enabling it, regardless of its settings, seems to be the cause

@3v1n0
Copy link
Collaborator

3v1n0 commented Dec 7, 2021

Please, explain exactly how to reproduce because it's not clear to me.

If it's about the fact that using arrow-keys while moving around the search text, moves the focus to the app icons, that's an upstream bug/feature as well.

@yoursred
Copy link
Author

yoursred commented Dec 7, 2021

I guess it's a combination of gnome and the extension
ezgif-3-028a676f4f63
.

@JustCryen
Copy link

I've been having the same issue for quite some time.
I just narrowed it down to Dash To Dock but nothing more.
For now I can confirm that either disabling the extension or Intelligent Autohide feature fixes it.
OS: archlinux
Gnome: gnome-shell 1:41.1-1

@yoursred
Copy link
Author

I want to add another thing, it only happens with intelligent autohide when the dock is not extended and is on the left side of the screen.

@JustCryen
Copy link

You're right… sadly that's exactly how I use it.

@yoursred
Copy link
Author

I would recommend extending it until a fix is found

@JustCryen
Copy link

Actually, under Appearance, disabling "Shrink the dash" makes it work again.
That's something I can tolerate, extending it is too distracting for me.

@yoursred
Copy link
Author

Quite the bizarre bug

@rollflick
Copy link

The issue in Activities Overview only occurs for me after suspending, not after a reboot. Occurs whether using Wayland or Xorg (though maybe need to do reboot rather than just logging out, which I didn't do).

Turning off Ubuntu Dock in extensions seems to have sorted it for me. Never needed to do that before for this extension to work well.

@yoursred
Copy link
Author

I can confirm that it happens regardless of session type (Xorg or Wayland), but for me at least, it doesn't care about being woke up or a cold boot.

@JustCryen
Copy link

Same as @yoursred.
For now I just have "Shrink the dash" disabled.
Ideally I would like to turn it back on.

@sirianni
Copy link

sirianni commented Jan 6, 2022

Same issue here. Note that strangely this only happens when the dock is placed on the left. If I place the dock on bottom or right side of the screen then keyboard navigation works properly.

@muflone
Copy link

muflone commented Mar 13, 2022

Confirmed in GNOME 41.4 for Arch Linux

Disabling the dash reduce fixes the navigation

@S0llarCode
Copy link

S0llarCode commented Jun 14, 2022

Same in GNOME 42.2 with Wayland, Manjaro 21.2.6 (Arch Linux)
Dash to dock 72

Fixed when disabling "Intelligent autohide"


When "Intelligent autohide" is enabled and i try to navigate in my search, such as @yoursred #1612 (comment), messages like this appear.

journalctl -b 0 -e:

gnome-shell[944]: Timelines with detached actors are not supported. [<Gjs_ui_iconGrid_BaseIcon>:0x55ff47ec5d30] in animation of duration 100ms but not on stage.

@S0llarCode
Copy link

S0llarCode commented Jul 9, 2022

Additional bug report
GNOME 42.2 with Wayland, Manjaro 21.3.2 (Arch Linux)
Dash to dock 72

When "Intelligent autohide" is enabled and the maximum icon size number is odd (like 37px), then the same bug occurs. If the maximum icon size is changed to an even size (like 38px) then the bug disappears.

You can fix the bug by choosing a maximum icon size with a even number. Examples : 32px, 36px, 38px...

Fix idea..
Settings.ui

Change property step-increment by 2

  <object class="GtkAdjustment" id="icon_size_adjustment">
    <property name="lower">16</property>
    <property name="upper">128</property>
    <property name="step-increment">2</property>
    <property name="page-increment">10</property>
  </object>

@vanvugt
Copy link
Collaborator

vanvugt commented Sep 12, 2022

Downstream Ubuntu bug: https://launchpad.net/bugs/1979096

@siddhpant
Copy link

siddhpant commented Sep 12, 2022

On Sat, 9 Jul 2022 22:50 +0530 @S0llarCode wrote:

When "Intelligent autohide" is enabled and the maximum icon size number is odd (like 37px), then the same bug occurs. If the maximum icon size is changed to an even size (like 38px) then the bug disappears.

You can fix the bug by choosing a maximum icon size with a even number. Examples : 32px, 36px, 38px...

For me, the setting was already even. Changing it to an odd number works/fixes for me, i.e., restores the intended behaviour.

@soumyaDghosh
Copy link

soumyaDghosh commented Sep 13, 2022

Please, explain exactly how to reproduce because it's not clear to me.

If it's about the fact that using arrow-keys while moving around the search text, moves the focus to the app icons, that's an upstream bug/feature as well.

To reproduce this, in ubuntu specifically, install the gnome-4x-ui-improvements extension. Then logout and login. The overviews cannot be seen anymore. Disable the hide search bar option in the above said extension, things will work again.

@3v1n0
Copy link
Collaborator

3v1n0 commented Sep 24, 2022

Wondering if commit 3431f5f has anything to do with this...

@siddhpant
Copy link

siddhpant commented Sep 26, 2022

On Sat, 24 Sep 2022 at 13:58 +0530, @3v1n0 wrote:

Wondering if commit 3431f5f has anything to do with this...

I am still experiencing the bug after updating to v74 (i.e. even number icon size breaks the search), so the commit probably doesn't fully address the bug...

@jabossu
Copy link

jabossu commented Oct 4, 2022

Additional bug report GNOME 42.2 with Wayland, Manjaro 21.3.2 (Arch Linux) Dash to dock 72

When "Intelligent autohide" is enabled and the maximum icon size number is odd (like 37px), then the same bug occurs. If the maximum icon size is changed to an even size (like 38px) then the bug disappears.

You can fix the bug by choosing a maximum icon size with a even number. Examples : 32px, 36px, 38px...

Fix idea.. Settings.ui

I can confirm this solution worked for me.

  • Manjaro (up to date)
  • Dash-To-Dock v74
  • Other extensions enabled : Caffeine, Emoji Selector, GSConnect

3v1n0 added a commit to 3v1n0/dash-to-dock that referenced this issue Oct 9, 2022
For some reason we need to use an even value, this is probably due to
the fact that such value is going to be proportional to the available
space.

Closes: micheleg#1612
3v1n0 added a commit to 3v1n0/dash-to-dock that referenced this issue Oct 9, 2022
For some reason we need to use an even value, this is probably due to
the fact that such value is going to be proportional to the available
space.

Closes: micheleg#1612
@3v1n0 3v1n0 linked a pull request Oct 9, 2022 that will close this issue
3v1n0 added a commit to 3v1n0/dash-to-dock that referenced this issue Oct 9, 2022
For some reason we need to use an even value, this is probably due to
the fact that such value is going to be proportional to the available
space.

Closes: micheleg#1612
LP: #1979096
@3v1n0
Copy link
Collaborator

3v1n0 commented Oct 9, 2022

Please check if #1849 solves the issue.

3v1n0 added a commit to 3v1n0/dash-to-dock that referenced this issue Oct 9, 2022
For some reason we need to use an even value, this is probably due to
the fact that such value is going to be proportional to the available
space.

Closes: micheleg#1612
LP: #1979096
3v1n0 added a commit that referenced this issue Oct 13, 2022
For some reason we need to use an even value, this is probably due to
the fact that such value is going to be proportional to the available
space.

Closes: #1612
LP: #1979096
3v1n0 added a commit that referenced this issue Jan 9, 2023
For some reason we need to use an even value, this is probably due to
the fact that such value is going to be proportional to the available
space.

Closes: #1612
LP: #1979096
3v1n0 added a commit that referenced this issue May 12, 2023
For some reason we need to use an even value, this is probably due to
the fact that such value is going to be proportional to the available
space.

Closes: #1612
LP: #1979096
@3v1n0 3v1n0 reopened this May 31, 2023
3v1n0 added a commit to 3v1n0/dash-to-dock that referenced this issue May 31, 2023
We were allocating the ControlsManagerLayout using the whole work area
geometry but then in the auto-hide mode we were reducing the size of the
available area again, creating problems when the available space was
reduced. Leading to non-clickable or activatable search results.

To prevent this, perform layout allocation using the available space
even when the dock is in autohide mode.

Closes: micheleg#1612
LP: #1979096
@3v1n0
Copy link
Collaborator

3v1n0 commented May 31, 2023

This does not seem to have really fixed in all the cases, but the good news is that it looks like I got a solution at #2020

3v1n0 added a commit that referenced this issue Jun 2, 2023
We were allocating the ControlsManagerLayout using the whole work area
geometry but then in the auto-hide mode we were reducing the size of the
available area again, creating problems when the available space was
reduced. Leading to non-clickable or activatable search results.

To prevent this, perform layout allocation using the available space
even when the dock is in autohide mode.

Closes: #1612
LP: #1979096
3v1n0 added a commit that referenced this issue Jun 2, 2023
We were allocating the ControlsManagerLayout using the whole work area
geometry but then in the auto-hide mode we were reducing the size of the
available area again, creating problems when the available space was
reduced. Leading to non-clickable or activatable search results.

To prevent this, perform layout allocation using the available space
even when the dock is in autohide mode.

Closes: #1612
LP: #1979096
3v1n0 added a commit that referenced this issue Jun 2, 2023
We were allocating the ControlsManagerLayout using the whole work area
geometry but then in the auto-hide mode we were reducing the size of the
available area again, creating problems when the available space was
reduced. Leading to non-clickable or activatable search results.

To prevent this, perform layout allocation using the available space
even when the dock is in autohide mode.

Closes: #1612
LP: #1979096
hasecilu pushed a commit to hasecilu/dash-to-dock that referenced this issue Oct 10, 2023
We were allocating the ControlsManagerLayout using the whole work area
geometry but then in the auto-hide mode we were reducing the size of the
available area again, creating problems when the available space was
reduced. Leading to non-clickable or activatable search results.

To prevent this, perform layout allocation using the available space
even when the dock is in autohide mode.

Closes: micheleg#1612
LP: #1979096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
12 participants