docking: Do ControlsManagerLayout allocation with box-adjusted workArea #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were allocating the ControlsManagerLayout using the whole work area geometry but then in the auto-hide mode we were reducing the size of the available area again, creating problems when the available space was reduced. Leading to non-clickable or activatable search results. To prevent this, perform layout allocation using the available space even when the dock is in autohide mode. Closes: micheleg#1612 LP: #1979096
We used different behavior depending on the state, but we can just be consistent and reduce the vertical space used in the same way
|
Whatever the remaining bug is that this fixes, I can't reproduce it. The original bug seems fixed on |
|
It's not easy to reproduce, but I generally get it in a FullHD setup where non-fractional scaling at 200% is enabled + dock as autohide, and it does fixes #1979096 for good in this case (which previous fix was not enough for). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were allocating the ControlsManagerLayout using the whole work area geometry but then in the auto-hide mode we were reducing the size of the available area again, creating problems when the available space was reduced. Leading to non-clickable or activatable search results.
To prevent this, perform layout allocation using the available space even when the dock is in autohide mode.
Closes: #1612
LP: #1979096