Update for Gnome Shell 46 #2146

sergio-costas · 2024-02-12T16:18:05Z

add_actor() has been removed after being deprecated, and it must be replaced with add_child(). Also, there are two add methods that also have to be changed.

Tested in Gnome 46 alpha, in a Fedora RawHide system. I also tested it in Gnome 45, but doesn't work, so it must be only 46.

sergio-costas · 2024-02-14T09:40:36Z

In fact, using this patch in Gnome Shell 45 results in a tiny, empty dock, and a lot of messages in journal like this one:

Can't update stage views actor <unnamed>[<XXXXXXX>:0xYYYYYYYY] is on because it needs an allocation.

ryzendew · 2024-02-15T14:31:05Z

issues to report

With shrink the dash icons pop up over the dock line

and without

icons are too far up

when transparent icons have weird circles

sergio-costas · 2024-02-15T15:17:10Z

@ryzendew Are you using Gnome 45 or Gnome 46?

sergio-costas · 2024-02-15T15:34:55Z

Ok, there are some extra problems:

JS ERROR: TypeError: (intermediate value).cairo_set_source_color is not a function
_drawIndicator@file:///home/raster/.local/share/gnome-shell/extensions/ubuntu-dock@ubuntu.com/appIconIndicators.js:411:17

For some reason, it can't find that function. Also

Error: No signal 'actor-added' on object 'MetaWindowGroup'

Stack trace:
  _create@file:///home/raster/.local/share/gnome-shell/extensions/ubuntu-dock@ubuntu.com/utils.js:172:30


Error: No signal 'actor-removed' on object 'MetaWindowGroup'

Stack trace:
  _create@file:///home/raster/.local/share/gnome-shell/extensions/ubuntu-dock@ubuntu.com/utils.js:172:30

I'll try to fix them...

metadata.json

sergio-costas · 2024-02-15T17:13:07Z

More things to fix:

The GObject property St.ScrollView.hscroll is deprecated.
0 ensureActorVisibleInScrollView() ["file:///home/raster/.local/share/gnome-shell/extensions/ubuntu-dock@ubuntu.com/dash.js":1113:38]

sergio-costas · 2024-02-15T17:14:56Z

Fixed the cairo_set_source_color bug.

sergio-costas · 2024-02-15T17:49:02Z

And fixed the signal problem.

sergio-costas · 2024-02-15T17:50:26Z

@ryzendew I'm unable to reproduce those errors. Can you try again with the new changes that I added, just in case?

ryzendew · 2024-02-15T23:09:16Z

@ryzendew Are you using Gnome 45 or Gnome 46?

46 beta

ryzendew · 2024-02-15T23:12:45Z

also no change with the newest change

rastersoft · 2024-02-15T23:27:10Z

@ryzendew Can you tell me your dock configuration? (icon size...)

ryzendew · 2024-02-16T12:04:56Z

this needs to be rebased on the beta cause the alpha is 1 month old and the beta has a few changes

sergio-costas · 2024-02-19T16:28:48Z

There are still several bugs in Gnome 46 beta:

The icons have incorrect size, as @RyzenDev commented
The "push to show" option doesn't work: if it is selected, pushing in the dock zone doesn't make it to pop up
The overview mode is broken: this message is shown in the log: clutter_actor_allocate: assertion '!isnan (real_allocation.x1) && !isnan (real_allocation.x2) && !isnan (real_allocation.y1) && !isnan (real_allocation.y2)' failed

sergio-costas · 2024-02-26T12:22:46Z

The "push to show" option fails because the data sent from Gnome Shell is... odd... I don't know if it's a problem from Gnome Shell itself and its PressureBarriers, or is a problem due to being using VirtualBox. The problem is that, once the mouse cursor is at the screen border, it doesn't matter how hard you move it against the border, the distance indicated by the barrier is always 0.765625, so unless you achieve the required pressure in the first "push", the dock won't appear.

sergio-costas · 2024-02-27T12:19:13Z

I've been able to fix the Overview problem in Gnome 46. It was because maybeAdjustBoxSize() and maybeAdjustBoxToDock() were being called with this.spacing as the last parameter, but that property isn't defined anywhere, so the received value was undefined, and this broke the allocation values (it put NaN in several places).

I just added a check to set it to zero if the value is undefined, but maybe it is possible to just fully remove the parameter itself, because it seems to be used only when calling those two methods, and I can't find neither other places where those methods are called, nor other places where the property is set. @3v1n0 What do you think?

sergio-costas · 2024-02-27T12:20:03Z

I decided to convert this into a draft to avoid merges until it is fully finished.

sergio-costas · 2024-02-29T15:23:06Z

Ok, it is ready for reviewing.

3v1n0

Some comments, mostly on style (but it does matter because CI will block it otherwise), but it works really well... So thanks a lot for working on this!

appIconIndicators.js

theming.js

utils.js

windowPreview.js

docking.js

_stylesheet.scss

ryzendew · 2024-03-01T03:35:07Z

Great work but you missed the show apps icon it's still has black around it

sergio-costas · 2024-03-01T11:31:02Z

Great work but you missed the show apps icon it's still has black around it

Ops!!! Fixed.

3v1n0 · 2024-03-01T13:50:15Z

Ah, for your info, I've landed this to ubuntu yesterday, so also consider the fixups I did at https://github.com/micheleg/dash-to-dock/tree/ubuntu-dock

jbicha · 2024-03-02T15:03:44Z

In case you weren't already aware, I'm missing the indicator next to running apps in the Ubuntu Dock. This is with 89ubuntu1 that is now in Ubuntu 24.04 LTS. And I'm using GNOME Shell 46~beta-0ubuntu2 and I'm still using the same Yaru theme as Ubuntu 23.10.

rastersoft · 2024-03-02T21:01:57Z

@jbicha I don't understand... Can you put me a screen capture?

muhammad-ans · 2024-03-02T21:43:13Z

There is also this weird square around app icons in overview when it is installed.

This patch fixes the placement error in the app icons

While it's safe to use either in GNOME 46, it is not always safe to use (clutter_actor_)add_child directly in GNOME 45. Because the notification StBin requires to update its internal state wasn't added until gnome-shell@ed3b8d093e introduced in 46.alpha. At least (st_bin_)set_child remains the same in all GNOME versions, and is what the old (clutter_container_)add_actor used to call in GNOME 45. There may be other places where we need to change add_child to set_child for backward compatibility with StBin, but if they exist then they're not causing problems yet. Closes: https://bugs.launchpad.net/bugs/2056506 Fixes: 4945dbf

sergio-costas · 2024-03-18T15:18:24Z

@karuboniru @garrett It should be fixed now. Thanks for testing it!

vanvugt · 2024-03-19T01:50:31Z

If you're using >100% scale then there's also an upstream fix coming for the dots: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3245

vanvugt · 2024-03-19T07:44:22Z

The dots are still misplaced (in GNOME 46 only?):

vanvugt

Conditionally approved pending the dot-over-the-icon bug mentioned above. It still seems to be happening in GNOME 46.0 at least.

sergio-costas · 2024-03-19T10:15:15Z

@vanvugt But, if I get it right, the patch for the dot problem is for Gnome Shell itself...

DScalpel · 2024-03-19T15:30:58Z

Hi,
Thanks for the extension update. I have one bug to report.

The Customize the dash color seems to leave weird artifacts around each icon with brown color.

I am using Arch linux gnome unstable repo.

sergio-costas · 2024-03-19T16:49:36Z

@DScalpel I can't reproduce your bug... Did you update to the last version of THIS branch?

bam80 · 2024-03-19T17:58:06Z

Thanks for the extension update.

It wasn't updated yet, right? I see no new releases.

DScalpel · 2024-03-19T18:24:35Z

@DScalpel I can't reproduce your bug... Did you update to the last version of THIS branch?
@sergio-costas
Hi, Sorry for bad bug report.

Can confirm it is working fine.

Calosis · 2024-03-19T19:17:32Z

The dots are still misplaced (in GNOME 46 only?):

Can confirm, I'm hitting this bug currently.

vanvugt · 2024-03-20T02:15:55Z

@vanvugt But, if I get it right, the patch for the dot problem is for Gnome Shell itself...

That's a slightly different bug where the gap exists but is only half the correct size. Here however, the gap does not exist (or has negative spacing?). Try it on GNOME 46 again...

vanvugt · 2024-03-20T03:12:43Z

Merged, but the dot bug on GNOME 46 is unresolved still. So it's not ready for release but at least we can all work more efficiently by focussing on the master branch.

a1ex-ak · 2024-03-20T09:18:48Z

Gnome 46

vanvugt · 2024-03-20T09:23:33Z

This pull request is closed. Please subscribe to #2160 instead.

stuarthayhurst · 2024-03-20T21:16:22Z

More things to fix:

The GObject property St.ScrollView.hscroll is deprecated.
0 ensureActorVisibleInScrollView() ["file:///home/raster/.local/share/gnome-shell/extensions/ubuntu-dock@ubuntu.com/dash.js":1113:38]

Did this get addressed? I'm still seeing it on my system, I'm happy to file a bug if that's not expected or tracked somewhere already :)

vanvugt · 2024-03-21T01:16:23Z

That's being tracked in #2159

a1ex-ak · 2024-03-21T14:52:03Z

Tell me when the update for Gnome 46 will be released

nechodom · 2024-03-22T19:14:06Z

Tell me when the update for Gnome 46 will be released

I already have Gnome 46. So I think you can download it.

vanvugt · 2024-03-25T01:36:09Z

dash-to-dock for GNOME 46 has not been released yet. Most likely because there are other issues we'd still like to fix, and we're working on other projects too.

3v1n0 reviewed Feb 15, 2024

View reviewed changes

metadata.json Outdated Show resolved Hide resolved

sergio-costas marked this pull request as draft February 27, 2024 12:19

sergio-costas marked this pull request as ready for review February 29, 2024 15:21

sergio-costas requested a review from 3v1n0 February 29, 2024 15:21

3v1n0 reviewed Feb 29, 2024

View reviewed changes

sergio-costas mentioned this pull request Mar 1, 2024

Update Yaru to new Dash-to-Dock code ubuntu/yaru#4051

Merged

sergio-costas force-pushed the update_to_gnome_shell_46 branch from 77ffa18 to 5b8787e Compare March 1, 2024 15:34

sergio-costas and others added 6 commits March 18, 2024 16:00

Fix position error

4191811

This patch fixes the placement error in the app icons

Remove the gray background in each icon

68e0203

Show the currently focused application

de35ab6

Nitpicks requested

5f6d27c

Remove unneeded settings in overview-til

3759956

sergio-costas force-pushed the update_to_gnome_shell_46 branch from d167b92 to 42ee745 Compare March 18, 2024 15:04

Fix odd rectangle in apps view

8349757

vanvugt reviewed Mar 19, 2024

View reviewed changes

vanvugt mentioned this pull request Mar 20, 2024

Fix dockmanager null #2148

Closed

vanvugt merged commit 506dd02 into micheleg:master Mar 20, 2024
1 check passed

7HE-W0R1D mentioned this pull request Mar 28, 2024

[Feature Request] GNOME 45 Support harshadgavali/gnome-gesture-improvements#206

Open

Update for Gnome Shell 46 #2146

Update for Gnome Shell 46 #2146

Conversation

sergio-costas commented Feb 12, 2024

sergio-costas commented Feb 14, 2024

ryzendew commented Feb 15, 2024

sergio-costas commented Feb 15, 2024

sergio-costas commented Feb 15, 2024

sergio-costas commented Feb 15, 2024

sergio-costas commented Feb 15, 2024

sergio-costas commented Feb 15, 2024

sergio-costas commented Feb 15, 2024

ryzendew commented Feb 15, 2024

ryzendew commented Feb 15, 2024

rastersoft commented Feb 15, 2024

ryzendew commented Feb 16, 2024

sergio-costas commented Feb 19, 2024 • edited Loading

sergio-costas commented Feb 26, 2024

sergio-costas commented Feb 27, 2024

sergio-costas commented Feb 27, 2024

sergio-costas commented Feb 29, 2024

3v1n0 left a comment

Choose a reason for hiding this comment

ryzendew commented Mar 1, 2024

sergio-costas commented Mar 1, 2024

3v1n0 commented Mar 1, 2024

jbicha commented Mar 2, 2024

rastersoft commented Mar 2, 2024

muhammad-ans commented Mar 2, 2024

sergio-costas commented Mar 18, 2024

vanvugt commented Mar 19, 2024

vanvugt commented Mar 19, 2024 • edited Loading

vanvugt left a comment

Choose a reason for hiding this comment

sergio-costas commented Mar 19, 2024

DScalpel commented Mar 19, 2024

sergio-costas commented Mar 19, 2024

bam80 commented Mar 19, 2024

DScalpel commented Mar 19, 2024 • edited Loading

Calosis commented Mar 19, 2024

vanvugt commented Mar 20, 2024 • edited Loading

vanvugt commented Mar 20, 2024

a1ex-ak commented Mar 20, 2024 • edited Loading

vanvugt commented Mar 20, 2024

stuarthayhurst commented Mar 20, 2024

vanvugt commented Mar 21, 2024

a1ex-ak commented Mar 21, 2024

nechodom commented Mar 22, 2024

vanvugt commented Mar 25, 2024

sergio-costas commented Feb 19, 2024 •

edited

Loading

vanvugt commented Mar 19, 2024 •

edited

Loading

DScalpel commented Mar 19, 2024 •

edited

Loading

vanvugt commented Mar 20, 2024 •

edited

Loading

a1ex-ak commented Mar 20, 2024 •

edited

Loading