Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP 5.4 and 5.5 from auto testing and update README #296

Merged
merged 3 commits into from
Mar 19, 2018

Conversation

michaelbutler
Copy link
Contributor

I've removed PHP 5.4 and PHP 5.5 from the auto testing because it's too much hassle to get both old and new PHPUnit working in the same repository. The newer PHPUnit has to be used to test against PHP 7.0 and 7.1, so it's recommended that be the priority.

Also updated the README so the travis-ci build status is shown at the top.

@michaelbutler
Copy link
Contributor Author

One can see that Travis-CI has passed this build ✔️

@michelf
Copy link
Owner

michelf commented Mar 19, 2018

I was wondering whether it'd be reasonably achievable to fix this instead of disabling the tests. If we need two different versions of PHPUnit, then I agree it's too much hassle.

Also updated the README so the travis-ci build status is shown at the top.

I've always disliked the aesthetics of those badges. Can we go without?

Also, I think your editor inadvertently removed all the trailing double spaces from the Readme. Those spaces are significant — they create line breaks — and so they should stay there.

One can see that Travis-CI has passed this build ✔️

Yes! I was looking forward to your pull request just for that. 💯 Great work.

@michaelbutler
Copy link
Contributor Author

Understand your concern about the badge; my only thought on that is (without really any proof to back it up) visitors may trust a project more when they can see it runs with automated tests. It's not important though for now though, will remove.

Let me try a few things to see if it is possible with composer to have it install the most appropriate PHPUnit version.

@michaelbutler
Copy link
Contributor Author

Looks like that did it! Now running fine on PHP 5.4 and PHP 5.5 too. This works because PHPUnit's API is backwards compatible but they changed it in 6.0 I believe.

@michelf michelf merged commit 6da3fe3 into michelf:lib Mar 19, 2018
@michaelbutler michaelbutler deleted the mbutler/travis-ci-2 branch June 1, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants