Update ProbeService.java ready only if running #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation is running In kubernetes, readiness are used to determine if a loadbalancer can forward request to a pod. If a pod declare that he is ready, he will receive traffic. The readiness for a kafka stream application is useful if we want to deploy a rest endpoint on top of it like an interactive query. (https://docs.confluent.io/platform/current/streams/developer-guide/interactive-queries.html) In such a case, we do not want a pod to pretend that it is ready if it is rebalancing, since it is potentially transferring state stores and therefore a potentially inconsistent state.
Jsebayhi
changed the title
|
@Jsebayhi Good catch, thank you |
loicgreffier
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kubernetes, readiness are used to determine if a loadbalancer can forward request to a pod. If a pod declare that he is ready, he will receive traffic. (https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-readiness-probes)
The readiness for a kafka stream application is useful if we want to deploy a rest endpoint on top of it like an interactive query. (https://docs.confluent.io/platform/current/streams/developer-guide/interactive-queries.html) In such a case, we do not want a pod to pretend that it is ready if it is rebalancing, since it is potentially transferring state stores and therefore is in a potentially inconsistent state.