Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProbeService.java ready only if running #133

Merged
merged 1 commit into from
Nov 27, 2023

Commits on Nov 23, 2023

  1. Update ProbeService.java readiness to report ready only if the applic…

    …ation is running
    
    In kubernetes, readiness are used to determine if a loadbalancer can forward request to a pod.
    If a pod declare that he is ready, he will receive traffic.
    
    The readiness for a kafka stream application is useful if we want to deploy a rest endpoint on top of it like an interactive query. (https://docs.confluent.io/platform/current/streams/developer-guide/interactive-queries.html)
    In such a case, we do not want a pod to pretend that it is ready if it is rebalancing, since it is potentially transferring state stores and therefore a potentially inconsistent state.
    Jsebayhi committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e76612b View commit details
    Browse the repository at this point in the history