Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid that test_somd.py fails due to OpenMM nan issues #110

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

ptosco
Copy link
Contributor

@ptosco ptosco commented Aug 12, 2019

If test_somd.py fails due to a RuntimeError: Particle coordinate is nan error, it should pass with a warning rather than failing, as it is not really a problem with BSS or SOMD.

…s nan" error, it should pass with a warning rather than failing
@ptosco
Copy link
Contributor Author

ptosco commented Aug 12, 2019

@lohedges I noticed that occasionally test_somd.py fails due to OpenMM issues with minimising coordinates. This should not be flagged as as a BSS failure (as I myself initially thought when I first saw the failure), as it is not really BSS, SOMD or SIre's fault and it may just happen randomly.

@lohedges
Copy link
Member

Thanks. I agree that this is a random failure and should be flagged accordingly. Do you have any idea why you are seeing it on your system, since it hasn't yet occurred in any of the Azure Pipeline builds (hundreds of builds on Linux and macOS), or in any of my local tests. Perhaps the version of OpenMM that you are using is different?

@lohedges lohedges merged commit df82e3b into michellab:devel Aug 12, 2019
@ptosco
Copy link
Contributor Author

ptosco commented Aug 12, 2019

I have seen this on Windows using OpenMM 7.3.0. To trigger it I ran 1000 times the tests and have only seen it a few times. I will try doing the same on Linux to see if it is a Windows-only thing.

@ptosco ptosco deleted the testsomd branch August 12, 2019 10:10
@ptosco
Copy link
Contributor Author

ptosco commented Aug 12, 2019

OK, I have reproduced this also on Linux, using OpenMM 7.3.0.

for i in `seq 1000 2000`; do
    sire_python -m pytest -v test/Process/test_somd.py > test_somd_${i}.log 2>&1
done

After ~150 runs I checked the logs and found one nan failure:

grep -iw nan test_somd_????.log
test_somd_1043.log:  /build/BioSimSpace/test/Process/test_somd.py:62: RuntimeWarning: Test raised RuntimeError: Particle coordinate is nan
test_somd_1043.log:    _warnings.warn("Test raised RuntimeError: Particle coordinate is nan", RuntimeWarning)

@lohedges
Copy link
Member

Thanks for taking the time to check this. I guess I have just been very lucky this far :-)

@ptosco
Copy link
Contributor Author

ptosco commented Aug 12, 2019

I'll check if using OpenMM 7.3.1 makes a difference and get back to you.

annamherz pushed a commit that referenced this pull request Sep 18, 2023
Expose Sire "make whole" functionality. [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants