Fix for array to string conversion Twig exception #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem discussed in michelsalib#83 where a Twig runtime exception is thrown when one of the job arguments is an array (which is always the case with jobs which support a retry strategy). More here: michelsalib#83
|
I realized that the draw back of this solution is that in production mode, the dump(...) function is disabled in symfony2. So this won't work in production. Anyone has an alternative? Worst case, we make a child template through which we recursively loop argvalue. |
|
Why not doing a json_encode ? With the associated twig filter ? |
|
@michelsalib ha, sounds good. Converted into Commited it in my PR. This looks better! |
|
Great! Thanks! |
michelsalib
pushed a commit
that referenced
this pull request
Feb 21, 2014
Fix for array to string conversion Twig exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem discussed in #83 where a Twig runtime exception is thrown when one of the job arguments is an array (which is always the case with jobs which support a retry strategy).
More here: #83