New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defined show
and show_in_iruby
methods
#236
Open
Shekharrajak
wants to merge
7
commits into
michelson:master
Choose a base branch
from
Shekharrajak:iruby_setup
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
17d603b
IRuby.display works now for high_chart
Shekharrajak 22fe502
testcases, better interface and examples
Shekharrajak a317089
removed high_chart_iruby
Shekharrajak 9c24858
minor chage
Shekharrajak acc4905
minor change in tests
Shekharrajak f69da73
notebook example added
Shekharrajak 415ad0a
added notebook examples in spec/dummy_iruby
Shekharrajak File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,10 @@ def high_chart(placeholder, object, &block) | |
high_graph(placeholder, object, &block).concat(content_tag("div", "", object.html_options)) | ||
end | ||
|
||
def high_chart_iruby(placeholder, object, &block) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Display nothing. @michelson can you check why it doesn't work ? |
||
IRuby.html(high_chart(placeholder, object, &block)) | ||
end | ||
|
||
def high_stock(placeholder, object, &block) | ||
object.html_options.merge!({:id => placeholder}) | ||
object.options[:chart][:renderTo] = placeholder | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
if(window['jquery'] === undefined || | ||
window['highcharts'] === undefined){ | ||
var path = <%= dep_libraries.merge(additional_libraries).to_json %>; | ||
|
||
<% | ||
shim = dep_libraries.merge(additional_libraries).inject({}){|hash, (k, v)| hash[k]={exports: k};next hash} | ||
%> | ||
|
||
var shim = <%= shim.to_json %>; | ||
|
||
require.config({paths: path, shim:shim}); | ||
|
||
<% | ||
str="" | ||
dep_libraries.each do |key, val| | ||
str.concat("require(['%s'], function(%s){window['%s']=%s;console.log('finished loading %s');"% Array.new(5, key)) | ||
end | ||
%> | ||
<%= str %> | ||
|
||
var script = jquen.select("head") | ||
.append("script") | ||
.attr("src", "http://code.highcharts.com/highcharts.js") | ||
.attr("async", true); | ||
|
||
script[0][0].onload = script[0][0].onreadystatechange = function(){ | ||
<% | ||
str="" | ||
additional_libraries.each do |key, val| | ||
str.concat("require(['%s'], function(%s){window['%s']=%s;console.log('finished loading %s');"% Array.new(5, key)) | ||
end | ||
%> | ||
<%= str %> | ||
var event = document.createEvent("HTMLEvents"); | ||
event.initEvent("load_highcharts",false,false); | ||
window.dispatchEvent(event); | ||
console.log('Finished loading highchartsjs'); | ||
<%= | ||
str = Array.new(additional_libraries.length, "});").join("") | ||
%> | ||
}; | ||
|
||
<% | ||
str = Array.new(dep_libraries.length, "});").join("") | ||
%> | ||
<%= str %> | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
if (window['jquery'] === undefined || window['highcharts'] === undefined) { | ||
<% | ||
all_libraries = dep_libraries.merge(additional_libraries) | ||
all_libraries.each do |name, path| | ||
basename = File.basename(path) | ||
contents = IO.read(File.join(js_dir, basename), mode: 'r:UTF-8') | ||
%> | ||
/* BEGIN <%= name %>.js */ | ||
<%= contents %> | ||
/* END <%= name %>.js */ | ||
<% end %> | ||
|
||
var event = document.createEvent("HTMLEvents"); | ||
event.initEvent("load_highcharts", false, false); | ||
window.dispatchEvent(event); | ||
console.log("Finish loading highchartsjs"); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assets= :cdn
is not working . I don't know why.