Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting changes #66

Closed
wants to merge 1 commit into from
Closed

Linting changes #66

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 6, 2023

This pull request includes linting changes based on the target branch.

Please review and merge if everything looks good.

Additional suggestions: ./tasks/types.ts organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

 1  1 │   import {
 2    │ - ··IAttributeData,
 3    │ - ··ITagData,
 4    │ - ··HTMLDataV1,
    2 │ + ··HTMLDataV1,
    3 │ + ··IAttributeData,
    4 │ + ··ITagData,
 5  5 │     IValueData,
 6  6 │   } from "vscode-html-languageservice";

./tasks/types.ts internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Fixes applied to the file, but there a still diagnostics to address.

./tasks/TypesFactory.ts organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

  1     │ - import·{·appendFileSync,·mkdirSync,·rmSync,·writeFileSync·}·from·"fs";
  2     │ - import·{·DEFAULT_VALUE_SET,·generateInterface,·sortByName·}·from·"./shared";
  3     │ - import·{·IAttributeData·}·from·"vscode-html-languageservice";
  4     │ - import·{
  5     │ - ··AddTypesFromProps,
  6     │ - ··AttributeSet,
  7     │ - ··InterfaceFactory,
  8     │ - ··ValueSetInterfaceFactory,
  9     │ - }·from·"./types";
      1 │ + import·{·DEFAULT_VALUE_SET,·generateInterface,·sortByName·}·from·"./shared";
      2 │ + import·{
      3 │ + ··AddTypesFromProps,
      4 │ + ··AttributeSet,
      5 │ + ··InterfaceFactory,
      6 │ + ··ValueSetInterfaceFactory,
      7 │ + }·from·"./types";
      8 │ + import·{·appendFileSync,·mkdirSync,·rmSync,·writeFileSync·}·from·"fs";
      9 │ + import·{·IAttributeData·}·from·"vscode-html-languageservice";
 10  10 │   
 11  11 │   const getInterfaceHelperName = (

./tasks/TypesFactory.ts internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Fixes applied to the file, but there a still diagnostics to address.

./tasks/shared.ts organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

 2  2 │   // TODO: fix this
 3  3 │   
 4    │ - import·{·IAttributeData,·MarkupContent·}·from·"vscode-html-languageservice";
    4 │ + import·{·allAttributes·}·from·"./TypesFactory";
 5  5 │   import { InterfaceFactory, JSDocInfo, ValueSetInterfaceFactory } from "./types";
 6    │ - import·{·allAttributes·}·from·"./TypesFactory";
    6 │ + import·{·IAttributeData,·MarkupContent·}·from·"vscode-html-languageservice";
 7  7 │   
 8  8 │   const getReferences = (currentValue: JSDocInfo) =>

./tasks/shared.ts internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Fixes applied to the file, but there a still diagnostics to address.

./tasks/generateTypes.ts organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

  1   1 │   import { TypesFactory } from "./TypesFactory";
  2     │ - import·htmlDataImport·from·"@vscode/web-custom-data/data/browsers.html-data.json";
  3     │ - import·svgDataImport·from·"@michijs/vscode-svg/dist/svg.json";
      2 │ + import·{·AttributeSet·}·from·"./types";
      3 │ + import·mathmlDataImport·from·"@michijs/vscode-mathml/dist/mathml.json";
  4   4 │   import svgAttributeSet from "@michijs/vscode-svg/dist/attributeSets.json";
  5     │ - import·mathmlDataImport·from·"@michijs/vscode-mathml/dist/mathml.json";
  6     │ - import·{·HTMLDataV1,·ITagData·}·from·"vscode-html-languageservice";
  7     │ - import·{·AttributeSet·}·from·"./types";
      5 │ + import·svgDataImport·from·"@michijs/vscode-svg/dist/svg.json";
      6 │ + import·htmlDataImport·from·"@vscode/web-custom-data/data/browsers.html-data.json";
      7 │ + import·{·HTMLDataV1,·ITagData·}·from·"vscode-html-languageservice";
  8   8 │   
  9   9 │   let htmlData = htmlDataImport as HTMLDataV1;

./tasks/generateTypes.ts internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Fixes applied to the file, but there a still diagnostics to address.

./src/generated/MathMLElements.ts organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

      1 │ + import·{·MathMLEvents·}·from·"../Events";
      2 │ + import·{·DataGlobalAttributes·}·from·"../types";
  1   3 │   // file generated from @michijs/vscode-mathml 1.0.2
  2   4 │   // HTML Data Version 1.1
  3   5 │   import { AllAttributes } from "./AllAttributes";
  4     │ - import·{·ValueSets·}·from·"./ValueSets";
  5     │ - import·{·MathMLEvents·}·from·"../Events";
  6     │ - import·{·DataGlobalAttributes·}·from·"../types";
      6 │ + import·{·ValueSets·}·from·"./ValueSets";
  7   7 │   interface GlobalAttributes
  8   8 │     extends Pick<

./src/generated/MathMLElements.ts internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Fixes applied to the file, but there a still diagnostics to address.

./src/generated/HTMLElements.ts organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

        1 │ + import·{·GlobalEvents,·WindowEvents·}·from·"../Events";
        2 │ + import·{·DataGlobalAttributes·}·from·"../types";
   1    3 │   // file generated from @vscode/web-custom-data 0.4.6
   2    4 │   // HTML Data Version 1.1
   3    5 │   import { AllAttributes } from "./AllAttributes";
   4      │ - import·{·ValueSets·}·from·"./ValueSets";
   5      │ - import·{·GlobalEvents,·WindowEvents·}·from·"../Events";
   6      │ - import·{·DataGlobalAttributes·}·from·"../types";
        6 │ + import·{·ValueSets·}·from·"./ValueSets";
   7    7 │   type GlobalAttributes = Pick<
   8    8 │     AllAttributes,

./src/generated/HTMLElements.ts internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Fixes applied to the file, but there a still diagnostics to address.

./src/Events/GlobalEvents.ts organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

  6   6 │     TypedFocusEvent,
  7   7 │     TypedFormDataEvent,
  8     │ - ··TypedMouseEvent,
  9     │ - ··TypedKeyboardEvent,
      8 │ + ··TypedKeyboardEvent,
      9 │ + ··TypedMouseEvent,
 10  10 │     TypedPointerEvent,
 11  11 │     TypedProgressEvent,
 12     │ - ··TypedSubmitEvent,
     12 │ + ··TypedSecurityPolicyViolationEvent,
     13 │ + ··TypedSubmitEvent,
 13  14 │     TypedTouchEvent,
 14  15 │     TypedTransitionEvent,
 15     │ - ··TypedWheelEvent,
 16     │ - ··TypedUIEvent,
 17     │ - ··TypedSecurityPolicyViolationEvent,
     16 │ + ··TypedUIEvent,
     17 │ + ··TypedWheelEvent,
 18  18 │   } from "./TypedEvents";
 19  19 │   import { TypedInputEvent } from "./TypedEvents/TypedInputEvent";

./src/Events/GlobalEvents.ts internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Fixes applied to the file, but there a still diagnostics to address.

./src/generated/SVGElements.ts organizeImports ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i Import statements could be sorted:

        1 │ + import·{·SVGEvents·}·from·"../Events";
        2 │ + import·{·DataGlobalAttributes·}·from·"../types";
   1    3 │   // file generated from @michijs/vscode-svg 2.0.6
   2    4 │   // HTML Data Version 1.1
   3    5 │   import { AllAttributes } from "./AllAttributes";
   4      │ - import·{·ValueSets·}·from·"./ValueSets";
   5      │ - import·{·SVGEvents·}·from·"../Events";
   6      │ - import·{·DataGlobalAttributes·}·from·"../types";
        6 │ + import·{·ValueSets·}·from·"./ValueSets";
   7    7 │   type GlobalAttributes = Pick<
   8    8 │     AllAttributes,

./src/generated/SVGElements.ts internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Fixes applied to the file, but there a still diagnostics to address.

Checked 45 file(s) in 30ms
Found 8 error(s)
internalError/io ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Some errors were emitted while running checks

@github-actions github-actions bot closed this Sep 6, 2023
@github-actions github-actions bot deleted the master_lint branch September 6, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants