Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support zipped artwork #175

Closed
nguillaumin opened this issue Jan 4, 2016 · 4 comments
Closed

Support zipped artwork #175

nguillaumin opened this issue Jan 4, 2016 · 4 comments

Comments

@nguillaumin
Copy link

Hi,

Unless I'm mistaken zipped artwork is not supported? For example all my MAME snapshots are in a single snap.zip file under my MAME snap/ folder (so snap/snap.zip) but I need to unzip them all into individual files for Attract Mode.

Supporting zipped artwork would be nice, especially since it's supported by MAME and also because popular artwork sources provide artwork DAT files in a format that results in them being zipped (A single machine XML tag where each snapshot is a rom tag, resulting in a single <machine>.zip file by popular DATs/ROMs managers).

Cheers,

Nico
mickelson added a commit that referenced this issue Jan 7, 2016
@mickelson
Issue #175 - Support zipped artwork
d38c6a4 
- adding a zip/rar/etc file to an emulator's configured artwork paths will
now cause the frontend to look for artworks inside that zip file
- file_names located in a zip file are shown to scripts in the following
format: <archive>|<internal_file_name>
- images and sounds should (!) be loadable from archives using this same
format.  i.e. `obj.filename = "~/my_zip|snappy.png";`
@mickelson
Copy link
Owner

ok, changes made. any testing you can do using the nightly build in a couple of days would be appreciated!!

@nguillaumin
Copy link
Author

Wow I wasn't expecting it to be implemented so soon, Thanks!

I tested the latest Git version and it works, however:

  • I wasn't expecting to have to put the path to the ZIP file in the config, I thought it would find it by itself in the folder (the same way it can find images). Not a big deal I guess...
  • It freezes at startup for ~10s presumably to process the ZIP file (My snap.zip is 1.3GB big). It's understandable but it seems the screen / OpenGL surface is not properly initialised when it does so so I get an odd image which is partly a screenshot of my desktop. It may be desirable to replace it with a progress message or something?
  • Browsing games is also significantly slower, with a 0.5s - 2s delay between each game, presumably to fetch the artwork from the ZIP file. Not sure what can be done there...

So it's good enough for me, but it may benefit from a little polishing!

Cheers,

Nico

@mickelson
Copy link
Owner

Good timing, I've had some time on my hands the last few days to fix things up.

I think requiring the path be right to the zip file is the only sane way to do this, due to the way Attract-Mode searches for all the various artworks resources. With respect to the time its taking to load and browse, I've gone and added a caching mechanism that should speed this up. Let me know if it is faster for you in the newer build.

@nguillaumin
Copy link
Author

Thanks, I've tested the latest version and it's much better. I still freezes the very first time to load all the artwork, but after that browsing games is very smooth and if I restart it loads snappily without freezing.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nguillaumin @mickelson