Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiting game results in relaunch of same game #266

Closed
DSX-FX opened this issue Sep 23, 2016 · 16 comments
Closed

Exiting game results in relaunch of same game #266

DSX-FX opened this issue Sep 23, 2016 · 16 comments

Comments

@DSX-FX
Copy link

DSX-FX commented Sep 23, 2016

Multiple users from the RetroPie group on fb are reporting an issue where exiting a game results in the game closing and immediately re-launching. Does not happen in emulationstation, only attract mode. Doesn't matter which emulator or system you are in, or what type of controller. Exiting with an arcade stick or a wireless keyboard will generate the same issue on the same system. Any ideas of what is causing this problem and what a potential fix might be?

@DSX-FX DSX-FX changed the title Exiting game results in relaunch so same game Exiting game results in relaunch of same game Sep 23, 2016
@ghost
Copy link

ghost commented Sep 23, 2016

Is attract mode now part of retropie?

@DSX-FX
Copy link
Author

DSX-FX commented Sep 23, 2016

You can install it and switch between emulation station or attract mode. It will let you default to either one.

@DSX-FX
Copy link
Author

DSX-FX commented Sep 26, 2016

After testing various devices, seems to only happen while using keyboard or keyboard based controller boards. Wireless keyboard, wired keyboard, and picade pcb all produce the bug using (c+s) to exit a game. Using a Logitech F310, I have not been able to produce the bug at all, not once. Not sure why this is happening as coding is not my strength...

@csavvas
Copy link

csavvas commented Oct 11, 2016

I have the same issue. It seems like that it remembers the keys pressed in game and when exiting is pressing all those keys again.

@mickelson
Copy link
Owner

In the configuration menu you can change the "Window Mode" setting (General->Window Mode)

Does switching Window Mode to "Fill Screen" or "Fullscreen Mode" affect whether this happens?

@bakazm
Copy link

bakazm commented Oct 15, 2016

I was having the same issue (pi3, keyboard inputs, AM 2.1) - looks like keypresses are being cached and passed onto attract mode when MAME exits. I tried switching to Fill Screen and Fullscreen, but they did not solve the problem.

@leakyscab
Copy link

I'm having same problem. Has anyone come across a solution? At first it was only a mild frustration however recently the "cached" keystrokes entered settings menus and made a real mess of things that I have yet to resolve.

@bakazm
Copy link

bakazm commented Nov 3, 2016

This problem does not occur on Floob's v.2 image, which still relied on the X environment. It looks like the newer versions that don't require X have the extra keystroke problem. For now I'm running v.2 until it gets sorted out.

mickelson added a commit that referenced this issue Nov 4, 2016
…non-X11)

- Also addresses a related UI responsiveness (menus etc) bug when using
keyboard-based input
@mickelson
Copy link
Owner

OK this bug should be fixed now with the most recent commit. Confirmation whether it fixes the issue for you would be appreciated. thanks!

@DSX-FX
Copy link
Author

DSX-FX commented Nov 4, 2016

I will try it out tomorrow and let you know! Thanks!

@DSX-FX
Copy link
Author

DSX-FX commented Nov 4, 2016

It appears to have solved the issue. The only thing I noticed was that sometimes when exiting a game, it would jump over to a different system's display or a different game wheel when no directional buttons had been pushed, only the exit combo (start+select). Definitely an improvement though! Thanks for looking into it!

@bakazm
Copy link

bakazm commented Nov 4, 2016

The issue is much better, but I still get an occasional "Exit Attract Mode?" prompt when I exit a game. My exit key for MAME is ESC, the same key as Attract Mode. So if anything, only one key press is being cached / repeated.

I also have a new, separate issue where I am unable to type any text in the Attract Mode settings screens, but the up/down/select keys work. This is likely a completely separate issue...

@cyborgcnc
Copy link

cyborgcnc commented Jan 10, 2017

Hi....I am still having this issue, on version 2.2.1 (just did a new install from the github sources). I am running on a pi 3 with latest build of retropi, but had the same issue on previous 2 retropi versions....Once I exit a mame game, it remembers my escape and enter keypresses, sometimes causing the next rom, or the same rom to run again....
I am using an IPAC controller, but I have the same issue with a plain vanilla USB keyboard....Also, changing the window modes, does not have any effect on the issue.....

I also have tried disabling the Advmame exit menu (Through Misc Safequit option) to see if this has any effect, but again, it remembers the keypress on exit...not sure what else to try....

Any ideas?

@mickelson
Copy link
Owner

mickelson commented Jan 10, 2017 via email

@cyborgcnc
Copy link

cyborgcnc commented Jan 10, 2017 via email

@M4rc3lv
Copy link

M4rc3lv commented Dec 4, 2017

Thanks for this Andrew. I have been working for months on a physical arcade cabinet using attract-mode and after playing some games I just found out that it worked bad because of this keyboard buffer problem. Your well documented solution worked perfectly. Thanks again!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants