Improved SWF loading speed #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved sf::Context to FePresent, so it's shared between all SWF instances. Moved glOrtho() to FePresent to avoid Y axis flipping when glOrtho() is called more than once in a shared context.
Fixed vram leak (caused by the previous commit) by encapsulating all m_texture calls within the swf_context. Moved m_texture to heap so it can be cleared after activating the context. Added missing flag check so the swf does not start when NoAutoStart flag is set. Removed redundant glPushAttrib which was throwing GL_STACK_OVERFLOW Removed unneccesary setSmooth() Moved get_swf_context() call to the FeSwf constructor.
|
Have you had time to take a look at this PR? Currently SWF loading is very laggy. This fix speeds up the SWF loading 10x or more. |
|
Thanks for this. MY preference is to continue with the model of keeping the swf-rendering specific code in swf.cpp/swf.hpp... take a look at #524 which I think should have the same loading improvement as this PR, let me know if you have any concerns... |
mickelson
added a commit
that referenced
this pull request
Dec 26, 2018
* alternative implementation of Oomek's work in PR #509 * Instead of creating a context for each swf object we now reuse a single context for all swf * removed call to glPushAttrib( GL_ALL_ATTRIB_BITS )
|
Implemented with #524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The speed gain is quite significant as shown in the video.
https://youtu.be/Y7nlfugz5wo
Detailed description in commits.