Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose embedAs object key for twitter video embeds #4

Merged
merged 3 commits into from Jun 20, 2016
Merged

expose embedAs object key for twitter video embeds #4

merged 3 commits into from Jun 20, 2016

Conversation

nazar
Copy link
Contributor

@nazar nazar commented Jun 14, 2016 •
edited

referenced micnews/embeds#24 - expose embedAs object key for twitter video embeds.

Depends on PR#30

@nazar nazar mentioned this pull request Jun 14, 2016
Merged
@nazar
Copy link
Contributor Author

nazar commented Jun 20, 2016

Hey @kesla - I've also updated this PR to fix merge conflicts and also point to embeds@^2.5.0

@kesla kesla merged commit 0cf66cd into micnews:master Jun 20, 2016
@kesla
Copy link
Contributor

kesla commented Jun 20, 2016

awesome, thank you

@kesla
Copy link
Contributor

kesla commented Jun 20, 2016

@iefserge do we need to make any updates to article-json-to-apple-news and/or article-json-to-amp to support this?

@ellell FYI - we might want to look at adding support for this in article-json-to-content-editable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nazar @kesla