Add support for twitter video embeds.

[mikelax]

Addresses issue #24

[orrybaram]

@iefserge and @kesla can chime in here, but I think we're sticking with deku ^1.0.0 for now, which is why you might have been getting these element errors.

[nazar]

hey @orrybaram - not sure why the tests failed specifically on node 4 only. npm test passed on my host (v4.4.3) and also on travis for node 4 and 0.10

[nazar]

but I think we're sticking with deku ^1.0.0 for now,

deku ^1.0.0 was under devDependencies and I added "deku": "^2.0.0-rc16" under dependencies to match the deku version in article-json-to-fbia (as that package had issues when deku attempted to render virtual-element elements) where I notice that the embeds package is held back to ^1.4.2.

I ran npm test under v4.4.5 (to match travis) on my dev and all tests pass. Would it be possible to re-run the travis tests again? I had a quick look but was not able to.

[nazar]

This PR is required by html-to-article-json#58 and article-json-to-fbia#4

[nazar]

Hey @iefserge and @kesla,

Any updates on the status of this PR? I'd be more than happy to offer any clarifications or further commits to address any concerns you might have.

Thanks!

[iefserge]

@nazar I agree, I think we should keep using deku@1 for now. We can upgrade later to the stable deku@2 when available, but it's going to be a major release.

[nazar]

Thanks for the update @iefserge - as far as I can tell, doku@1 is only required for the tests.

The bigger issue I think is the removal of virtual-element which didn't work when embeds@2 is being used by article-json-to-fbia which itself uses deku@2 but an older version of embeds@^1.4.2

Should we have branched off embeds@1.5.0 instead for adding the twitter-video support for article-json-to-fbia? I'll also try and revert back to deku@1

[kesla]

Hey,

We should merge micnews/article-json-to-fbia#2 to move article-json-to-fbia to deku@1 then we can merge this as well (with deku@1 support).

@nazar sorry for the confusion

[nazar]

Thanks @kesla - that makes a lot of sense now :D - I'm moving this to deku@1

[nazar]

Hey @kesla - reverted to use deku@1 and magic-virtual-element

[kesla]

@nazar ty

[kesla]

@nazar released in 2.5.0!

[mikelax]

Thanks a lot @kesla.

[kesla]

@mikelax No, thank you. This is a feature that we'll definitely will have good use of ourselves!