Separate interface package system_modes_msgs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated msg and srv types into seperate package . This seems to be the ROS 2 way anyway, was requiring a hack beforehand, and seems necessary to get windows build working. Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
Adapts system_modes and system_modes_example packages to separated system_modes_msgs interface package. Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
ralph-lange
requested changes
Apr 19, 2021
Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 32.63% 31.87% -0.77%
==========================================
Files 14 14
Lines 1048 1048
Branches 754 754
==========================================
- Hits 342 334 -8
- Misses 132 136 +4
- Partials 574 578 +4
Continue to review full report at Codecov.
|
ralph-lange
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated msg and srv types into seperate package
system_modes_msgs. This seems to be the ROS 2 way anyway, was requiring a hack beforehand, and seems necessary to get the windows build working. (I have a working windows build based on this change now)