-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Studio-NDTiffAdapter: Simplifies function getImagesMatching() #1840
Conversation
so that it does no longer go through the complete dataset. This may lead to problems in certain cases, but at least makes virtual datasets readable again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check, is the intent not to change what getImagesMatching()
returns, but to change how it computes the matching set?
This may lead to problems in certain cases
Which cases?
I believe it now only returns an exact match, so no longer the super set (i.e., if one only asks for channel == 1, it should return all images with channel == 1). I do not know how to implement that behavior with the NDTiffStorage back-end. |
(Edit) I thnink the problem is that a function that reads the metadata but not the image had never been added to the NDTiff API. I just added one: |
return axesStream.map(new Function<HashMap<String, Object>, Image>() { | ||
@Override | ||
public Image apply(HashMap<String, Object> axes) { | ||
TaggedImage ti = addEssentialImageMetadata(storage_.getImage(axes), axes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the line that I think would need to change
To what? I do not really understand this code. |
from and then change the |
need to be worked on.
What I would need from the storage class is a method that tells which axes are available and which images (with axes coordinates) are in the dataset. It it unclear from the NDTiff Storage API is such a method exits, and documentation such as:
is not very helpful. I will merge this PR since it at least improves the situation, but welcome work on making this actually work right. |
so that it does no longer go through the complete dataset. This may lead to problems in certain cases, but at least makes virtual datasets readable again.
Closes #1839