Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade UI to a modern webapp framework #494

Merged
merged 227 commits into from
Oct 3, 2023
Merged

Upgrade UI to a modern webapp framework #494

merged 227 commits into from
Oct 3, 2023

Conversation

linknum23
Copy link
Contributor

@linknum23 linknum23 commented Aug 15, 2023 •
edited
Loading

This PR integrates pretty many UI changes made by @jonahshader and @klay2000 several months ago. The entire app/design was converted to react and made way less clunky.

If I recall there are several things to fix here:

  • Fix weird zone and stream issues ( we think we tracked these down to the backed at some point)
  • Deploy script fails on some conflicting dependencies

We should really merge this into develop so we can make issues on what is still broken and get feedback from users on the new interface.

linknum23 and others added 30 commits November 16, 2022 11:18
@linknum23
Add temporary server install
cf85297
@linknum23
Add 4 more virtual sources
cd7b593
@linknum23
Upgrade config inplace from 4->8 sources
69bea33
@linknum23
Fix web views to support virtual sources
6d78e12
@linknum23
Make tests pass
ae7eab9
@linknum23
Add 4 default lms streams connected to src 4-7
bb3f961
@linknum23
Alias ch0-3 from higher sources
b809374
@linknum23
Cleanup
ab119cf
@linknum23
Fix missed source id replacement/change
855dbeb
@linknum23
Prevent lms stream deletion
e77b8d2
@linknum23
Try to hook the sources 5-8 to lms clients if they exist
0fa7169
@linknum23
Handle protected stream deletion
08e2e6c
@linknum23
Fix weird source assignement aliasing
cd63da1 
This bug was missed in testing.
@linknum23
Hide virtual sources by aliasing them to zones and groups
dbb1777 
This should simplify the look of the user interface. TODO: add virtual sources display?
@linknum23
Only show actual sources
b83a0e9
@linknum23
Make utils.find simpler to use
2a43310
@linknum23
Add aliasing handling for source inputs and info
0e33537
@linknum23
Fix input selector bug
7b1cc82
@linknum23
Revert inverted unused_zones/groups logic
40a5011
@Lohrer
Hide virtual sources on the front-panel display
31aba82
@linknum23
Add default lms server for this build
2213c98
@linknum23
Fix typo
3fec1da
@linknum23
Bump release
0f7fd78
@linknum23
Add an identity file
e536cd6 
This allows an AmpliPi to be shallowly rebranded in the web app.
@linknum23
Add identity config to touchscreen
bd9ad1c 
This allows a different picture to be displayed while waiting for a connection
@linknum23
Merge remote-tracking branch 'origin/main' into identity
3e0f897
@linknum23
Bump pre-release version
52fbbdd
@linknum23
Handle missing touchscreen logo
93ecfcf
@linknum23
Put a dmixer in front of source 0
6613e37
@linknum23
Bump pre-release version
95979c0
rtertiaer and others added 24 commits August 30, 2023 15:00
@rtertiaer
Merge pull request #504 from micro-nova/Webapp2-RUM
5be6c7c 
ESLint + debug ElasticAPM RUM
@SteveMicroNova
Solution to issue #497
1062510
@SteveMicroNova
Merge branch 'webapp_2' into Webapp2-VolumeDropdown
47c9882
@SteveMicroNova
Removed unused comments, added new comments, tweaked the if statement…
4f74e26 
… to be more accurate to the goal
@SteveMicroNova
completing unfinished comment
e4b7409
@SteveMicroNova
Added CSS styling to home page card elements to add reactivity on var…
b46a613 
…ious clickables
@SteveMicroNova
Fix as per Jonah's request:
ab4802d 
#506 (review)
@SteveMicroNova
Changed chip to have highlight to it instead of the divs containing it
0510459
@SteveMicroNova
Merge pull request #506 from micro-nova/Webapp2-VolumeDropdown
2be8f3c 
Solution to issue #497
@SteveMicroNova
Upadtes as per request: #507 (review)
a16a0e5
@SteveMicroNova
spelling fix
0f7f743
@SteveMicroNova
Mixin update
746d765
@SteveMicroNova
Proper fixes to mixins, cleanup of scss files to move cursor into mix…
8c85246 
…in and out of scss declarations that use the relative mixins
@SteveMicroNova
Merge pull request #507 from micro-nova/Webapp2-HomeResponsiveness
8b302b8 
Webapp2 home responsiveness
@rtertiaer
add is_streamer attribute to /api/info
fc1768c
@rtertiaer
hide all zone/group functionality on streamers
3cd17d1
@rtertiaer
add & integrate StreamerOutputModal
9814619
@rtertiaer
some display tweaks for streamers
865766a
@rtertiaer
fix references to sourceId
6c8aeca
@rtertiaer
remove unused PlayerCard component
909f1b5
@rtertiaer
make a StreamerOutputBadge component
1a5edbf
@rtertiaer
clean up PropTypes
b666e64
@rtertiaer
pass in custom sourceId for streamer output selection
c65351f
@rtertiaer
fix css for new StreamerOutput* components
035096e
@linknum23 linknum23 marked this pull request as ready for review October 2, 2023 21:05
@rtertiaer
Copy link
Contributor

I've merged this into develop on localhost & deployed+tested on an amplified box & a streamer box; nothing seems amiss, though you're possibly aware of the edge cases on the backend I oughta pay attention to. @linknum23 are you opposed to me pulling the trigger, or do you have a list of tests you typically perform that I can validate this against?

@rtertiaer
Copy link
Contributor

I've tested bluetooth on this as well; works a charm. Merging.

@rtertiaer rtertiaer merged commit cbd1c5e into develop Oct 3, 2023
2 of 3 checks passed
@rtertiaer rtertiaer deleted the webapp_2 branch October 3, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@linknum23 @rtertiaer @Lohrer @jonahshader @klay2000 @SteveMicroNova