Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution to issue #497 #506

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Solution to issue #497 #506

merged 5 commits into from
Sep 7, 2023

Conversation

SteveMicroNova
Copy link
Contributor

@SteveMicroNova SteveMicroNova commented Aug 30, 2023 •
edited
Loading

@SteveMicroNova SteveMicroNova linked an issue Aug 30, 2023 that may be closed by this pull request
WebApp2 - Remove dropdown volume bar from the player screen in some cases #497
Closed
linknum23
linknum23 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@linknum23 linknum23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good.

jonahshader
jonahshader requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@jonahshader jonahshader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on the 'alone' state. Besides that, it seems to work and the code looks good!

web/src/pages/Player/Player.jsx Outdated Show resolved Hide resolved
@SteveMicroNova SteveMicroNova requested review from jonahshader and removed request for rtertiaer September 1, 2023 16:00
jonahshader
jonahshader approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@jonahshader jonahshader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SteveMicroNova
Copy link
Contributor Author

2/3 approvals seems good enough for me to merge, closing this request

@SteveMicroNova SteveMicroNova merged commit 2be8f3c into webapp_2 Sep 7, 2023
1 check passed
@linknum23 linknum23 deleted the Webapp2-VolumeDropdown branch November 21, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linknum23 linknum23 linknum23 approved these changes

@jonahshader jonahshader jonahshader approved these changes

@klay2000 klay2000 Awaiting requested review from klay2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebApp2 - Remove dropdown volume bar from the player screen in some cases
3 participants
@SteveMicroNova @linknum23 @jonahshader