Catch all panics and report them (#1365)

client/cli/signup/cli.go

@@ -67,7 +67,6 @@ func Run(ctx *cli.Context) error {
 	}, cl.WithRequestTimeout(10*time.Second))
 	if err != nil {
 		fmt.Printf("Error verifying: %s\n", err)
-		report.Errorf(ctx, "%v: Error verifying: %s", email, err)
 		os.Exit(1)
 	}
 
@@ -161,7 +160,6 @@ func Run(ctx *cli.Context) error {
 	}, cl.WithRequestTimeout(30*time.Second))
 	if err != nil {
 		fmt.Printf("Error completing signup: %s\n", err)
-		report.Errorf(ctx, "Error completing signup: %s", err)
 		os.Exit(1)
 	}
 

cmd/cmd.go

@@ -8,6 +8,7 @@ import (
 	"math/rand"
 	"os"
 	"os/exec"
+	"runtime/debug"
 	"sort"
 	"strings"
 	"time"
@@ -24,6 +25,7 @@ import (
 	uconf "github.com/micro/micro/v3/internal/config"
 	"github.com/micro/micro/v3/internal/helper"
 	"github.com/micro/micro/v3/internal/network"
+	"github.com/micro/micro/v3/internal/report"
 	_ "github.com/micro/micro/v3/internal/usage"
 	"github.com/micro/micro/v3/internal/wrapper"
 	"github.com/micro/micro/v3/plugin"
@@ -523,6 +525,12 @@ func (c *command) Init(opts ...Option) error {
 }
 
 func (c *command) Run() error {
+	defer func() {
+		if r := recover(); r != nil {
+			report.Errorf(nil, fmt.Sprintf("panic: %v", string(debug.Stack())))
+			panic(r)
+		}
+	}()
 	return c.app.Run(os.Args)
 }
 

go.mod

@@ -34,4 +34,4 @@ require (
 	google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013
 	google.golang.org/grpc v1.27.0
 	google.golang.org/protobuf v1.25.0
-)
+)

internal/report/report.go

@@ -84,6 +84,9 @@ type TrackingData struct {
 }
 
 func getTrackingCategory(ctx *cli.Context) string {
+	if ctx == nil {
+		return "cli"
+	}
 	command := helper.Command(ctx)
 	subcommand := helper.Subcommand(ctx)
 	if len(strings.TrimSpace(subcommand)) == 0 {