Prevent generation of default accounts #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asim
reviewed
Oct 9, 2020
cmd/cmd.go
Outdated
| @@ -126,6 +126,11 @@ var ( | |||
| EnvVars: []string{"MICRO_AUTH_PRIVATE_KEY"}, | |||
| Usage: "Private key for JWT auth (base64 encoded PEM)", | |||
| }, | |||
| &cli.BoolFlag{ | |||
| Name: "no_default_account", | |||
There was a problem hiding this comment.
--disable_admin / MICRO_AUTH_DISABLE_ADMIN
ben-toogood
suggested changes
Oct 9, 2020
ben-toogood
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes
Only generate default account in default namespace
Added
DisableAdminflag to even disable this behaviour. This is useful for security hardening purposes, ie. imagine data loss occuring and then an attacker being able to log in with default credentials.Added
--namespaceoption tomicro auth account createas test which previously depended on account being autogenerated after namespace change now must create an admin account in that namespace first.Fix
Test