Build fix #75
Merged
Build fix #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right: we should just finalize that package, and submit to Bioc, when time will allow.. .. and meanwhile indeed just remove from Suggests.. perhaps examples can be moved to miaTime package if useful. |
|
Yes, sure I just disabled miaTime examples and test using data from it because it seems to cause an error miaTime is using package SEtools which is using biocGenerics::rowSums --> rowSums has moved to MatrixGenerics Bioconductor/BiocGenerics@5d95680 |
|
Ok good to open issues in miaTime but seems you just opened some already. |
antagomir
approved these changes
Apr 3, 2023
TuomasBorman
added a commit
that referenced
this pull request
Apr 4, 2023
This reverts commit f76468f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
miaTime cannot even be in "suggests" as it causes an error in build https://master.bioconductor.org/checkResults/3.17/bioc-LATEST/miaViz/nebbiolo1-checksrc.html