Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove slots from Biosample & DataGeneration & update examples #42

Merged
merged 19 commits into from
Dec 20, 2023

Conversation

mslarae13
Copy link
Collaborator

@mslarae13 mslarae13 commented Dec 14, 2023

@mslarae13 mslarae13 changed the title remove nucl_acid_ext from Biosample & DataGeneration & update examples remove slots from Biosample & DataGeneration & update examples Dec 14, 2023
@mslarae13
Copy link
Collaborator Author

@aclum I removed pool_dna_extracts from Biosample. I know we have Class:Pooling. Is there a slot that we could add a close_mapping to? I looked at Pooling, but nothing popped out at me.

@mslarae13
Copy link
Collaborator Author

I completed the removal of MIxS slots. i think there's still some slots to be removed, but I'd like Alicia to take a look

@mslarae13
Copy link
Collaborator Author

remove seq_method from nucleotide sequencing and alias it for an instance of Class:Instrument

@mslarae13
Copy link
Collaborator Author

@turbomam IDK what this failed check means?

@turbomam turbomam merged commit f6cfc22 into main Dec 20, 2023
2 checks passed
@mslarae13 mslarae13 deleted the 1557-slot-moving-cont branch December 20, 2023 20:38
@brynnz22
Copy link
Collaborator

no migration needed - none of these slots are being used.

@brynnz22 brynnz22 changed the title remove slots from Biosample & DataGeneration & update examples remove slots from Biosample & DataGeneration & update examples Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants