Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused file #500

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix: remove unused file #500

merged 1 commit into from
Mar 26, 2024

Conversation

dwinston
Copy link
Collaborator

thanks @eecavanna

Description

Eric: I was surprised to see there is a nmdc.schema.json file in there. At a glance, it looks to me like a copy of the JSON Schema version of the NMDC schema, but it hasn't been updated (there) since it was first committed (some time last year). Is that being used by anything? Maybe it was used temporarily during early development and preserved in the repo by accident.

Donny: re: 1 -- yes, this was preserved by accident. The schema is loaded from the installed package, e.g. https://github.com/microbiomedata/nmdc-runtime/blob/v1.4.2/nmdc_runtime/minter/config.py#L17 to source typecodes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Inspection.

Configuration Details: none

Checklist:

n/a

@dwinston dwinston requested a review from eecavanna March 26, 2024 17:52
Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for removing this file.

@dwinston dwinston merged commit 24908dc into main Mar 26, 2024
@dwinston dwinston deleted the fix-orphaned-file branch March 26, 2024 18:01
dwinston added a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants