Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load optional info banner via env var #507

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

dwinston
Copy link
Collaborator

@dwinston dwinston commented Apr 19, 2024

Description

Supplement to microbiomedata/nmdc-server#1211

Fixes #506

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration, if it is not simply make up-test && make test-run.

Configuration Details: new env var INFO_BANNER_INNERHTML.

Checklist:

  • My code follows the style guidelines of this project (have you run black nmdc_runtime/?)
  • I have performed a self-review of my code

@PeopleMakeCulture PeopleMakeCulture merged commit 6936534 into main Apr 19, 2024
2 checks passed
@PeopleMakeCulture PeopleMakeCulture deleted the 506-nmdc-info-banner branch April 19, 2024 18:07
@eecavanna
Copy link
Collaborator

I tested several environment variable values on Rancher—letters only, letters and single quotes and double quotes, HTML wrapped in a single outermost element (i.e. everything within a single <span>...</span>), and HTML with multiple outermost elements. All of them worked the way I expected. In all of those cases, I wrote everything on a single line.

Here's the final one of those things:

<strong>Announcement:</strong> <span>The NMDC will be replacing legacy identifiers with <a href="https://microbiomedata.github.io/nmdc-schema/identifiers/#ids-minted-for-use-within-nmdc" target="_blank">NMDC persistent identifiers</a> on <strong>May 1, 2024</strong> for studies, samples, analysis workflows, and files. Additionally, annotation will be reprocessed for legacy metagenomes and metatranscriptomes, along with binning for metagenomes. Legacy metaproteomics datasets will be reprocessed using the new metagenome annotations. For information on mapping between old and new identifiers, please refer to <a href="https://microbiomedata.github.io/nmdc-schema/identifiers/#reuse-vs-minting-new-ids" target="_blank">this documentation</a>. If you have questions, please contact <a href="mailto: support@microbiomedata.org">support@microbiomedata.org</a>.</span>

image

Looks good to me! Thanks, @PeopleMakeCulture and @dwinston!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add banner to swagger ui
3 participants