Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RNA library permissible values to LibraryTypeEnum for LibraryPreparation's library_type slot #1000

Open
Tracked by #1466
aclum opened this issue Jun 15, 2023 · 6 comments
Labels
backlog Issue not assigned to a sprint or not completed during a sprint. Needs to be reprioritized.

Comments

@aclum
Copy link
Contributor

aclum commented Jun 15, 2023

Not urgent since it is not needed for NEON but we need a slot to capture the type of RNA library since this is needed input for Class MetatranscriptomeActivity

Proposed slot rna_seq_type

Propose enum for range with enumerations of
"Stranded RNA-seq, R1 is forward, R2 is reversed", "Stranded RNA-seq, R2 is forward, R1 is reversed", "non-stranded RNA-seq"

@aclum aclum added the backlog Issue not assigned to a sprint or not completed during a sprint. Needs to be reprioritized. label Jun 15, 2023
@aclum aclum mentioned this issue Jun 15, 2023
5 tasks
@turbomam
Copy link
Collaborator

OK. The permissible values for the enumeration should be very succinct, preferably a single word or something_snake_cased.

Class PermissibleValue takes most of the annotations as other LinkML meta classes

If we can find OBO foundry terms for those concepts, we should assign the term CURIEs to the meaning slot.

@mslarae13
Copy link
Contributor

Low priority. Mark can add this enum. Will need review.
If not completed next sprint will not be included in berk roll out.

@turbomam turbomam changed the title slot for specifying type of RNA library type for Class LibraryPreparation Add RNA library permissible values to LibraryTypeEnum for LibraryPreparation's library_type slot Mar 8, 2024
@turbomam
Copy link
Collaborator

turbomam commented Mar 8, 2024

@aclum I just rewrote your title like a cowboy, but then thought oops maybe I don't really know what you want.

Can we just add permissible values to the existing LibraryTypeEnum, or do you really feel like a new slot is required? I see that you are suggesting a new slot called rna_seq_type. Does that mean that you would want to have something like this?

id: nmdc:libprp-99-abc123
type: nmdc:LibraryPreparation
library_type: RNA 
rna_seq_type: stranded_rnaseq_r1f_r2r

There aren't any library_type values other than 'DNA' in the metadata I put into GraphDB a week or two ago, so eliminating the 'RNA' value wouldn't require a migration.

Is there any circumstance you would want to say that the library_type is 'RNA' without asserting a rna_seq_type?

@aclum
Copy link
Contributor Author

aclum commented Mar 9, 2024

I would prefer this as a separate slot since we may not have this information or we'll have to infer it from a combination of institution+processing date.

@aclum
Copy link
Contributor Author

aclum commented May 9, 2024

@turbomam do you have time work on this ticket this sprint? @kaijli and I are reviewing the workflow and will need this information as a workflow parameter for the counting step. We'll need to reprocess existing projects after re-iding b/c the new workflow uses a different assembler.

@mslarae13
Copy link
Contributor

re-iding needs to re-process metaT data. File type enum for metaT isn't sorted out.
Adding support for metaT allowed in soft freeze.
TBD, specific to 1 data type, so impacts shouldn't be huge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issue not assigned to a sprint or not completed during a sprint. Needs to be reprioritized.
Projects
None yet
Development

No branches or pull requests

3 participants