Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmdc database toold extract-records not catching all data object IDs not found in the database #1809

Closed
mbthornton-lbl opened this issue Mar 1, 2024 · 0 comments · Fixed by #1813
Assignees

Comments

@mbthornton-lbl
Copy link
Contributor

The tool is expecting a 404 response -

The data objects endpoint will give a valid 200 response like so:

10:14:17,97 root INFO Searching for data object nmdc:dobj-11-57yeca15.
10:14:17,206 root INFO {'detail': 'Not found'}

Need to catch this so as to:

For the sake of correctness, call these out as "MissingDataObject" in the log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant