Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEON soil metagenome story #917

Closed
turbomam opened this issue May 30, 2023 · 6 comments
Closed

NEON soil metagenome story #917

turbomam opened this issue May 30, 2023 · 6 comments
Assignees

Comments

@turbomam
Copy link
Collaborator

turbomam commented May 30, 2023

@aclum your example data and schema files were extremely helpful.

So far, I have copied and pasted, instead of merging. Then I have applied some modifications. Let me know how you want to reconcile what I have done to get good semantics, reuse, etc. vs what you need for the science.

@aclum
Copy link
Contributor

aclum commented May 30, 2023

Notes from the squad meeting

  • Either new class Protocol or generic slots for protocol information (name and url )
  • make extraction more generic and add to enum for valid values for extraction_type (DNA, RNA, metabolite, protein)
  • figure out what to do with has_input/has_inputs and has_output/has_outputs for Classes (Pooling,Extraction, LIbraryPreparation). has_inputs and has_outputs inherits from class PlannedProcess so it is confusing to also allow slots has_input and/or has_output. Proposal: use has_inputs and has_outputs and specify cardinality explicitly for a class. Make these slots required, otherwise we'll have orphaned records.

@aclum
Copy link
Contributor

aclum commented Jun 1, 2023

@turbomam I believe we are still missing syntax patterns for the new classes where we'll need to mint IDs
-ProcessedSample
-Pooling
-Extraction
-LibraryConstruction

@turbomam
Copy link
Collaborator Author

turbomam commented Jun 2, 2023

OK, I created a new issue for the identifier patterns and will complete it by mid day Monday.

@ssarrafan
Copy link
Collaborator

@turbomam @aclum can this issue be closed? All checkboxes are complete and there is a new issue #936

@aclum
Copy link
Contributor

aclum commented Jun 2, 2023

Up to @turbomam but I'd prefer to leave this open since there are changes in the corresponding branch, https://github.com/microbiomedata/nmdc-schema/tree/issue-917-neon-story, which still need to be merged in related to slots for analytical samples as well as date slots for Class ProcessedSamples. This branch contains the example valid data for #936 and #908, #906

@aclum
Copy link
Contributor

aclum commented Jun 15, 2023

Dependencies are resolved.

@aclum aclum closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants