Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should Biosample.slot_usage.slot_usage include range: Study? #940

Closed
dwinston opened this issue Jun 2, 2023 · 2 comments
Closed

should Biosample.slot_usage.slot_usage include range: Study? #940

dwinston opened this issue Jun 2, 2023 · 2 comments

Comments

@dwinston
Copy link
Collaborator

dwinston commented Jun 2, 2023

nmdc-schema/src/schema/nmdc.yaml

Line 1074 in 96d7919

part_of:

@dwinston dwinston changed the title should Biosample.slot_usage.slot_usage include range: Biosample? should Biosample.slot_usage.slot_usage include range: Study? Jun 2, 2023
@turbomam
Copy link
Collaborator

turbomam commented Jun 2, 2023

Do you mean the range for part_of, when used in class Biosample, should be Study?

I would agree with that.

@dwinston
Copy link
Collaborator Author

dwinston commented Jun 2, 2023

Yes, that’s what I mean.

@turbomam turbomam mentioned this issue Jun 9, 2023
Merged
@turbomam turbomam closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dwinston @turbomam