Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in geographic location (latitude and longitude) pattern hint #139

Closed
Tracked by #587
pvangay opened this issue Jun 24, 2022 · 11 comments
Closed
Tracked by #587

Typo in geographic location (latitude and longitude) pattern hint #139

pvangay opened this issue Jun 24, 2022 · 11 comments
Assignees

Comments

@pvangay
Copy link

pvangay commented Jun 24, 2022

Currently is: (lat lon}
Should be: {lat lon}

(reported by a Champion)

@turbomam
Copy link
Member

Where does(lat lon} appear?

@turbomam
Copy link
Member

modifications_long

@pvangay
Copy link
Author

pvangay commented Jun 24, 2022

image

I'm currently in the built environment template (example project)

@mslarae13
Copy link

This is correct in the src schema files. @turbomam where is this error at? Can you fix it?

@mslarae13
Copy link

Backlog until pattern hint (generated from string_serialization) is re-established

@mslarae13
Copy link

Error occurs in sheets_and_friends

I've corrected this in my working version of the sheet. See here: https://docs.google.com/spreadsheets/d/1Qc5dTdo39mNeMrE-WwVSz6SpjL0SiQ8vFfMrBF97804/edit#gid=928747012&range=2:2

When code freeze and schema sync is complete this should be merged into the 'official' sheet.

@ssarrafan
Copy link

I'll move this to the next sprint to be merged in. FYI @mslarae13

@ssarrafan
Copy link

@mslarae13 @turbomam was this merged? Can this issue be closed?

@mslarae13
Copy link

It wasn't merged. Waiting for the schema freeze to end
This should probably go into "in review"

@ssarrafan
Copy link

@pkalita-lbl @turbomam does this actually need to be reviewed by anyone still? It's been sitting here for 2 weeks.

@pkalita-lbl
Copy link
Collaborator

This one is suffering from extreme issue rot. I don't really know what the whole history is, and I'm not quite sure why I got added to the assignees. But I verified underlying bug has been fixed ({lat lon} is there instead of (lat lon}) by inspecting the schema. However you can't see the fix in the interface because of #170. Regardless I think it's time to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ SubPort 1 - Done
Development

No branches or pull requests

5 participants