Redirect potentially non Next Gen users to prototype version #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-grace
commented
Feb 29, 2024
•
microbit-grace
commented
- Shown to users before browser compatibility warning dialog
- Shown only if they are detected to be in the UK (GB), Isle of Man (IM), Jersey (JE), or Guernsey (GG)
- Should only be shown once to the user
- API proxy for calling browser info endpoint for local dev via .env
|
Preview build will be at |
microbit-grace
force-pushed
the
redirect-to-prototype
branch
2 times, most recently
from
209046f
to
21d30c5
Compare
…#243) - Shown to users before browser compatibility warning dialog - Shown only if they are detected to be in the UK (GB), Isle of Man (IM), Jersey (JE), or Guernsey (GG) - Should only be shown once to the user - API proxy for calling browser info endpoint for local dev via .env (cherry picked from commit 0aa4729)
microbit-grace
force-pushed
the
redirect-to-prototype
branch
from
21d30c5
to
35d0468
Compare
microbit-grace
changed the title
microbit-grace
requested review from
microbit-matt-hillsdon and
microbit-robert
| if (!get(hasSeenAppVersionRedirectDialog)) { | ||
| const { country } = await fetchBrowserInfo(); | ||
| const nextGenAvailableCountries = ['GB', 'JE', 'IM', 'GG']; | ||
| isPotentiallyNonNextGenUser = !nextGenAvailableCountries.includes(country || ''); |
There was a problem hiding this comment.
I find it strange that TypeScript complains about country being undefined, as it's perfectly valid code without the || '', nevermind.
microbit-matt-hillsdon
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.