Fix bug if lines don't match when mapping diagnostics #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The document may have changed in the meantime so notice when lines don't make sense. I've also added a specific check for the scenario where diagnostics have to < from. Closes #1062
|
Preview build will be at |
microbit-matt-hillsdon
changed the title
microbit-matt-hillsdon
changed the title
|
Tried point and range diagnostics and all seems to be working well. I don't think it's reasonable to be able to repro this via the UI so we'll have to rely on reviewing the logic of the fix and the tests. |
|
I'll monitor the impact on staging for a bit before releasing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document may have changed in the meantime so notice when lines don't make sense. I've also added a specific check for the scenario where diagnostics have to < from.
Closes #1062