add request option to custom baseUrl #56
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37 の #37 (comment) で打診した内容で、リクエストのbaseUrlを上書きできるようにしてみました。
テスト時のリクエスト先切り替え(stub化が漏れ、正しいURLにリクエストが飛ぶことを防げる)にも使えるのでオプションとしてはあってもいい気がしています。
リクエスト時に切り替えたいのでclientに持たせるのではなくリクエスト時のオプションにしてみました。