Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging): fixing writer bug with additional messages #22

Merged
merged 1 commit into from
Feb 16, 2018
Merged

fix(messaging): fixing writer bug with additional messages #22

merged 1 commit into from
Feb 16, 2018

Conversation

pbrzostowski
Copy link
Contributor

This fixes issue with writer that sends more messages then should. Please review and merge asap.

@GitCop
Copy link

GitCop commented Feb 16, 2018

There were the following issues with your Pull Request

  • Commit: 6982290
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/microdevs/missy


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Feb 16, 2018

There were the following issues with your Pull Request

  • Commit: 0c45b6f
  • Your subject line is longer than 72 characters

Guidelines are available at https://github.com/microdevs/missy


This message was auto-generated by https://gitcop.com

@pbrzostowski
Copy link
Contributor Author

tank you captain obvious :) I am not familiar with gitcop yet...

@levrik levrik changed the title fix(messaging) fixing writer bug that sends more messages then it should fix(messaging): fixing writer bug that sends more messages then it should Feb 16, 2018
@levrik levrik changed the title fix(messaging): fixing writer bug that sends more messages then it should fix(messaging): fixing writer bug with additional messages Feb 16, 2018
@levrik
Copy link
Contributor

levrik commented Feb 16, 2018

Just curious: How could that fail before?

@pbrzostowski
Copy link
Contributor Author

it was more than 72 characters in commit message ;/

@levrik
Copy link
Contributor

levrik commented Feb 16, 2018

@pbrzostowski No. I meant the code 🙂

Edit:
Ah, wait. Got it. It was appending to the already initialized slice.

@levrik levrik merged commit 3384e4a into microdevs:master Feb 16, 2018
@pbrzostowski
Copy link
Contributor Author

@levrik I was creating an array with fixed length then i was using append(..), that returns new slice and append my item at end of it... so it has at index 0 empty element... ;/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants