Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom URL for main url attribute instead for JSON and RSS feeds #129

Closed
wants to merge 1 commit into from

Conversation

jarylc
Copy link
Contributor

@jarylc jarylc commented Apr 15, 2024

When accessing the JSON and RSS feeds, I've noticed that the main url attribute for posts links to my pages.dev domain rather than my custom domain. Likely because I created the posts from there.

This PR changes it to be the same as _microfeed['web_url'] which will use the custom domain as base regardless.

@jarylc
Copy link
Contributor Author

jarylc commented Apr 15, 2024

I actually did just notice you can update the link in the Edit Item page.

Is that intentional? I do feel that the link shouldn't be saved unless it is for the canonical link, but I believe it is not.

Maybe it would make more sense for it to be path instead of link, but I can see it being useful in the rare case where the site has a proxy/mirror.

@jarylc jarylc closed this Apr 15, 2024
@wenbinf
Copy link
Member

wenbinf commented Apr 15, 2024

I actually did just notice you can update the link in the Edit Item page.

Is that intentional? I do feel that the link shouldn't be saved unless it is for the canonical link, but I believe it is not.

Maybe it would make more sense for it to be path instead of link, but I can see it being useful in the rare case where the site has a proxy/mirror.

Yes, an item's link can be updated. In some cases, an item includes nothing but an external link, e.g., https://www.wenbin.org/ , so it may be better to make the external link rather than the item's microfeed link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants