RequestId/responseTo in device protocol #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnor
force-pushed
the
fbp-responses
branch
2 times, most recently
from
ffcd7cf
to
0b0748a
Compare
Needed to be able to support requestId+respondTo
jonnor
force-pushed
the
fbp-responses
branch
5 times, most recently
from
361885e
to
492e6bb
Compare
A clear distinction in the host<->device protocol between request/response, and events (spontaneously created by runtime) Breaking protocol change: - Command size is increased from 8 bytes to 10 bytes - The first byte is now the request/response identifier, or 0 for events - PacketSent event no longer contains target node/port - PacketSent and SendPacket events have space for all 4 bytes of data - Magic string changed
jonnor
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref flowbased/fbp-protocol#60
Device communication level