Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we swap microformat-node for microformats-parser? #4

Closed
Zegnat opened this issue Dec 15, 2022 · 5 comments · Fixed by #5
Closed

Should we swap microformat-node for microformats-parser? #4

Zegnat opened this issue Dec 15, 2022 · 5 comments · Fixed by #5

Comments

@Zegnat
Copy link
Member

Zegnat commented Dec 15, 2022

Currently this page uses microformat-node (npm, GitHub) instead of the newer microformats-parser (npm, GitHub).

There are a couple of advantages to the newer microformats-parser even apart from just being newer. Such as using the standardised test suite and being owned by the Microformats organisation on GitHub.

I am happy to do a PR for this, but are there any reasons why we would not want to switch?

@gRegorLove
Copy link
Member

I'm not familiar with the current state of this, but there is also a fork of Glenn's microformat-node in this org: https://github.com/microformats/microformat-node

@Zegnat
Copy link
Member Author

Zegnat commented Dec 15, 2022

As far as I can tell, that fork has never been published to the npm Registry. So while there is a fork within the Microformats organisation it feels like it is more for historical purposes. When you install microformat-node from your standard Node/JavaScript package managers you will get the glennjones/microformat-node repo one.

@btrem
Copy link

btrem commented Dec 15, 2022

I'm confused. If the "fork has never been published" why does it get installed in a standard pkg manager?

@Zegnat
Copy link
Member Author

Zegnat commented Dec 15, 2022

@btrem can you elaborate?

From what I can see, npm install microformat-node will install the copy from https://github.com/glennjones/microformat-node. The copy of the same code that is at https://github.com/microformats/microformat-node does not install from any package managers.

But I might well be mistaken. Let me know if you see other results from your package manager!

@btrem
Copy link

btrem commented Dec 15, 2022

@Zegnat you are not mistaken; I was confused. After reading your reply (and re-reading your earlier comment), I now realize you were comparing the fork with its upstream original, and not comparing the glennjones parser with the newer microformats parser.

Sorry for the noise.

btrem added a commit to btrem/microformats.io that referenced this issue Dec 22, 2022
/microformats/microformats-parser-website-node/issues/4
is now resolved, with the newer node parser replacing
the Glenn Jones one.
This commit changes link to repo to match what the site
is using.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants