Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove location-related permissions from nearby-core package #1796

Closed
fynngodau opened this issue Sep 29, 2022 · 6 comments
Closed

Remove location-related permissions from nearby-core package #1796

fynngodau opened this issue Sep 29, 2022 · 6 comments

Comments

@fynngodau
Copy link
Contributor

We should still implement the behavior discussed here: #1707 (comment)

Then CCTG can use upstream's microG builds again (I think).

@Bubu
Copy link
Contributor

Bubu commented Sep 29, 2022

@mar-v-in
Copy link
Member

mar-v-in commented Oct 2, 2022

@fynngodau @Bubu mind checking if 7667cdd makes sense to you?

@Bubu
Copy link
Contributor

Bubu commented Oct 4, 2022

Looks good at first glance. Will hopefully get around to testing this soon.

@ale5000-git
Copy link
Member

ale5000-git commented Oct 4, 2022

Quote: https://developer.android.com/guide/topics/connectivity/bluetooth/permissions#discover-local-devices

If you want your app to initiate device discovery or manipulate Bluetooth settings, you must declare the BLUETOOTH_ADMIN permission. Most apps need this permission solely for the ability to discover local Bluetooth devices.
If your app supports a service and can run on Android 10 (API level 29) or Android 11, you must also declare the ACCESS_BACKGROUND_LOCATION permission to discover Bluetooth devices.

To my undertsanding ACCESS_BACKGROUND_LOCATION is still needed if you use BLUETOOTH_ADMIN.
But if the used functions of BLUETOOTH_ADMIN can be replaced by BLUETOOTH_SCAN and you place maxSdkVersion="30" to BLUETOOTH_ADMIN maybe it is fine.

@ale5000-git
Copy link
Member

ale5000-git commented Oct 6, 2022

@mar-v-in
@fynngodau
@Bubu

Edit: Moved the code here => #1610 (comment)

@mar-v-in mar-v-in added this to the 0.2.25 milestone Oct 21, 2022
@mar-v-in
Copy link
Member

Close via 0ade509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants