Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing MLKit API (say, for scanning QR codes / barcodes) #2018

Open
Iey4iej3 opened this issue Aug 27, 2023 · 15 comments
Open

Implementing MLKit API (say, for scanning QR codes / barcodes) #2018

Iey4iej3 opened this issue Aug 27, 2023 · 15 comments
Labels
📸 Vision Play Services Vision and MLKit Vision (Barcode Scanning, Face Recognition, Text Recognition)

Comments

@Iey4iej3
Copy link

Several issues are opened due to lack of MLKit API: #2003 #1966 #1881 #1753

This is also related to #395

I guess that the full implementation is hard, but implementing QR code / barcode scanner should be easier.

@Wojtaz0w
Copy link

I just wanted to mention that it is PARTIALY working, for example in DeepL translator app you can take a picture and highlight text, it gets recognised, no bugs there

@Iey4iej3
Copy link
Author

It might be better to document what (API) is working and what is yet to implement.

@mar-v-in mar-v-in added the 📸 Vision Play Services Vision and MLKit Vision (Barcode Scanning, Face Recognition, Text Recognition) label Dec 24, 2023
@Rua
Copy link

Rua commented Jan 10, 2024

I currently am unable to scan QR codes with the Dutch national identification app DigID because of this problem, which locks me out of some government services. Is there any progress on this?

@ltguillaume
Copy link

I currently am unable to scan QR codes with the Dutch national identification app DigID because of this problem, which locks me out of some government services. Is there any progress on this?

That doesn't make any sense. DigiD recently made changes to include a library to scan QR codes, making it independent of MLKit. See https://tweakers.net/nieuws/215204/inloggen-op-digid-app-kan-voortaan-ook-op-telefoons-zonder-googles-qr-scanner.html

@Rua Are you sure you're running the latest version?

@Rua
Copy link

Rua commented Jan 10, 2024

I just reinstalled the latest version (6.9.3) from the Play Store today (via Aurora).

@ale5000-git
Copy link
Member

There is a probable fix here: c104211
But there isn't any microG release yet.

@Iey4iej3
Copy link
Author

There is a probable fix here: c104211

It might be better to link the commit to this issue.

@ale5000-git
Copy link
Member

There are a lot of issues regarding this API and I'm not sure the commit fix everything, so it is better to wait the new version of microG and let the users test it before say anything else.
I will provide my custom build of microG when I get my main PC working again.

@konradmoesch
Copy link

I am testing (gmscore master branch) with the mlkit quickstart app (https://github.com/googlesamples/mlkit/tree/master/android/vision-quickstart), which can use bundled and unbundled libraries (changeable in the gradle dependencies). It seems that the bundled dependency (com.google.mlkit:barcode-scanning) works fine, but if I change to the unbundled version, I get dynamite errors
Whats the current status of this? Is somebody working on improving dynamite/mlkit support at the moment?

@ale5000-git
Copy link
Member

For those that want to test here there is my custom build of microG with all fixes included: https://github.com/micro5k/microg-unofficial-installer/raw/main/zip-content/origin/priv-app/GmsCore-ale5000.apk
Since it is signed by me you can't just update but you have to remove the version that you have installed before installing the new one.

@licaon-kter
Copy link

How far is this from being usable as a replacement for a random app that depends on Google's MLKit?

@Iey4iej3
Copy link
Author

This patch is already merged, and there are releases after the merge now. You can test yourself, I guess.

@Axolord
Copy link

Axolord commented May 27, 2024

At least https://play.google.com/store/apps/details?id=com.goodsnooze.soosee still crasges atm. I get the following crash log:

FATAL EXCEPTION: ImageAnalysis
Process: com.goodsnooze.soosee, PID: 22776
java.util.concurrent.ExecutionException: X3.a: Waiting for the text optional module to be downloaded. Please wait.
	at m3.Q2.B(Unknown Source:29)
	at s2.b.a(Unknown Source:653)
	at x.C.a(Unknown Source:2)
	at x.K.run(Unknown Source:65)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
	at java.lang.Thread.run(Thread.java:1012)
Caused by: X3.a: Waiting for the text optional module to be downloaded. Please wait.
	at v.e.a(Unknown Source:382)
	at E1.h0.run(Unknown Source:52)
	at k.h.run(Unknown Source:97)
	at K2.p.run(Unknown Source:28)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
	at K2.p.run(Unknown Source:53)
	... 1 more

@Iey4iej3
Copy link
Author

Iey4iej3 commented May 27, 2024

At least https://play.google.com/store/apps/details?id=com.goodsnooze.soosee still crasges atm. I get the following crash log:

The crash log does not seem to be closely related to MLKit. Maybe #309 is relevant?

@Iey4iej3
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📸 Vision Play Services Vision and MLKit Vision (Barcode Scanning, Face Recognition, Text Recognition)
Projects
None yet
Development

No branches or pull requests

9 participants