Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapbox libraries #1977

Merged
merged 2 commits into from Jul 8, 2023
Merged

Update mapbox libraries #1977

merged 2 commits into from Jul 8, 2023

Conversation

VxlerieUwU
Copy link
Contributor

@VxlerieUwU VxlerieUwU commented Jul 7, 2023

This fixes #969 but requires setting the minimum Android version to 5.0. It may need more testing since breaking changes may be present in org.maplibre.gl:android-sdk.

@ale5000-git
Copy link
Member

ale5000-git commented Jul 8, 2023

but requires setting the minimum Android version to ...

Or tools:overrideLibrary can be used to ovverride the minimum SDK value.

@fynngodau
Copy link
Contributor

Indeed, it's great that maplibre finally has a new release for the annotations plugin :)

Current microG contains version 10.0.0 of maplibre-native, which already requires API 21. We therefore instruct the manifest merger to ignore this here: https://github.com/microg/GmsCore/blob/master/play-services-maps-core-mapbox/src/main/AndroidManifest.xml#L32

Since version 2.0.0 of maplibre-plugins aligns its minSdk with maplibre-native, we should add com.mapbox.mapboxsdk.plugins.annotation in the same place. A small note, API 21 corresponds to Android 5, not 6.

It may need more testing since breaking changes may be present in org.maplibre.gl:android-sdk.

Fortunately this is not the case: 10.2.0 is documented to be identical to 10.0.2, which contains barely any changes, just like 10.0.1.

@mar-v-in
Copy link
Member

mar-v-in commented Jul 8, 2023

@VxlerieUwU I think you wanted to do

<uses-sdk tools:overrideLibrary="com.mapbox.mapboxsdk,com.mapbox.mapboxsdk.plugins.annotation" />

@VxlerieUwU
Copy link
Contributor Author

@VxlerieUwU I think you wanted to do

<uses-sdk tools:overrideLibrary="com.mapbox.mapboxsdk,com.mapbox.mapboxsdk.plugins.annotation" />

Thanks!

@mar-v-in mar-v-in merged commit 0e929a5 into microg:master Jul 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor map performance with many markers/layers
4 participants