Implement Licensing service #2069

fynngodau · 2023-10-04T11:56:19Z

Implemented as of now:

Licensing requests
Query multiple Google accounts
If no Google account is registered, show a notification
Query profile service
Query preference for whether licensing is enabled

ale5000-git · 2023-10-04T12:33:14Z

Hi,
is there a real need to bump JavaVersion?

ale5000-git · 2023-10-04T12:35:47Z

Also FakeStore can have a different signature of GmsCore and in this case maxSdkVersion on android.permission.GET_ACCOUNTS can break things.

fynngodau · 2023-10-04T13:15:48Z

Hi,
is there a real need to bump JavaVersion?

With the current Kotlin version, which needs to be included for wire (protobuf library), it seems that yes.

Also FakeStore can have a different signature of GmsCore and in this case maxSdkVersion on android.permission.GET_ACCOUNTS can break things.

I will remove the attribute.

mar-v-in · 2023-10-04T13:25:11Z

If you configure kotlin to be JVM 8 compatible, you can keep Java Version to 8 as well. We do the same everywhere else

    kotlinOptions {
        jvmTarget = 1.8
    }

fynngodau · 2023-10-04T14:39:46Z

@mar-v-in Thanks, applied.

ale5000-git · 2023-10-07T18:16:12Z

It isn't really a problem for me, bit since it contact a Google server many people would probably like to have a setting for it (disabled by default)

fynngodau · 2023-10-12T11:35:50Z

@ale5000-git Since fakestore doesn't have a UI, a setting for this can't easily be implemented. Note that the licensing request is only made if a Google account has been added. (Apps are also expected to have the com.android.vending.CHECK_LICENSE permission, but they can acquire it just by declaring it; I just added a commit that enforces that they have it.)

fynngodau · 2023-10-22T14:52:46Z

@ale5000-git Setting is added to UI in #2076.

ale5000-git · 2023-12-19T00:04:41Z

Now we need the code that checks for the preference since #2076 is merged :-)

Reviewed-at: https://gitlab.e.foundation/e/os/GmsCore/-/merge_requests/91#note_458642

fynngodau · 2023-12-19T08:55:56Z

Now we need the code that checks for the preference since #2076 is merged :-)

You are absolutely right. I'm getting all confused here with the many branches I'm handling. What is pushed now should make sense but maybe I got something confused yet again 😞

ale5000-git · 2023-12-19T14:10:28Z

I cannot test it currently but it seems fine 😃

ale5000-git · 2023-12-19T14:19:05Z

Just noticed a minor comment issue, here: https://github.com/microg/GmsCore/pull/2069/files#diff-93490511fa787a3e0c583ec081e5e22c2e49da9a8688b70db5b99168fbc7f7bcR40

NOT_LICENSED => The application is licensed to the user, but there is an updated application version ...

LICENSED_OLD_KEY => The application is not licensed to the user

Only the opposite make sense.

ale5000-git · 2023-12-21T21:54:40Z

@fynngodau
This commit seems to be missing from the PR: https://gitlab.e.foundation/e/os/GmsCore/-/commit/ca40063756c09793ce902662eeecbb74da61a924

ale5000-git · 2024-01-08T18:08:53Z

@fynngodau
In case you haven't yet noticed also this PR was already merged: #2071

fynngodau · 2024-01-11T22:21:54Z

Only the opposite make sense.

@ale5000-git Thank you, seems I swapped them on accident.

In case you haven't yet noticed also this PR was already merged: #2071

Yes, I noticed, I was just very busy and had no time to update this PR like planned. It should be good now, but I don't have the time to test the latest state as well as would be desirable.

fynngodau · 2024-01-11T22:39:57Z

vending-app/src/main/java/com/android/vending/licensing/LicenseServiceNotificationRunnable.java

@@ -70,7 +70,7 @@ public void run() {
        ignoreIntent.putExtra(INTENT_KEY_IGNORE_PACKAGE_NAME, callerPackageName);
        ignoreIntent.putExtra(INTENT_KEY_NOTIFICATION_ID, callerUid);
        PendingIntent ignorePendingIntent = PendingIntent.getBroadcast(
-            context, callerUid * 2 + 1, ignoreIntent, PendingIntent.FLAG_IMMUTABLE
+            context, callerUid * 2 + 1, ignoreIntent, PendingIntent.FLAG_MUTABLE


I have not one bit of an idea why, in my emulator tests, the INTENT_KEY_IGNORE_PACKAGE_NAME extra doesn't reach the receiver when FLAG_IMMUTABLE is set.

fynngodau · 2024-01-11T22:51:02Z

vending-app/build.gradle

@@ -17,6 +17,8 @@ android {
        versionCode vendingAppVersionCode
        minSdkVersion androidMinSdk
        targetSdkVersion androidTargetSdk
+
+        multiDexEnabled true


It seems the pipeline is failing due to the 65,536 method limit? I'm quite confused, as this is not happening locally. Anyhow, this commit is supposed to enable multidex, but I'm unsure if that's an appropriate solution in this case.

Now it have this lint error:

/home/runner/work/GmsCore/GmsCore/vending-app/src/main/java/com/android/vending/licensing/LicenseServiceNotificationRunnable.java:95: Error: Call requires permission which may be rejected by user: code should explicitly check to see if permission is available (with checkPermission) or explicitly handle a potential SecurityException [MissingPermission] notificationManager.notify(callerUid, notification);

Did you run also lint locally?

@ale5000-git I noticed the pipeline failing, but no, I haven't run the lint locally. I likely won't have time to fix this issue in the next days.

No problem, take your time.
Your contribution is really appreciated.

fynngodau · 2024-01-22T19:12:10Z

With the notifications lint issue solved, here comes the next lint issue:


> Task :vending-app:lintDefaultDebug FAILED
Lint found 1 errors, 4 warnings. First failure:

/home/runner/work/GmsCore/GmsCore/vending-app/src/main/res/values-ast: Error: The app will crash on platforms older than v21 (minSdkVersion is 14) because AssetManager#getLocales() is called (from the library jar file jars/classes.jar) and this folder resource name only works on v21 or later with that call present in the app [GetLocales]

   Explanation for issues of type "GetLocales":
   This check looks for usage of Lollipop-style locale folders (e.g. 3 letter
   language codes, or BCP 47 qualifiers) combined with an
   AssetManager#getLocales() call. This leads to crashes

I'm, uh, again, not sure why this is coming up even though the folder exists since 93e4884, which is included in master, and what a recommended solution would be.

ale5000-git · 2024-01-22T19:39:53Z

@fynngodau
You probably need to do something similar to this: f0b15d2

Like f0b15d2

mar-v-in · 2024-01-22T19:48:11Z

The GetLocales lint is a little bit buggy. It is triggered by the call to getLocales in play-services-base which has proper SDK version checks in place. However the lint check not only applies to source code, but also to binary dependencies. During the build process, play-services-base is built into a jar binary jars/classes.jar, that is then used from other modules (vending-app in this case). However the linter does not analyze the binary code in the same was as source code to determine if the call to getLocales has proper SDK version checks (or to look for @SuppressLint annotations).

That's why it triggers this lint in every submodule that uses play-services-base. The only thing we can do is to ignore the lint check.

fynngodau · 2024-01-22T20:40:51Z

@ale5000-git @mar-v-in Thanks for the pointer and explanation. I have disabled the faulty lint.

ale5000-git · 2024-01-23T12:11:35Z

@fynngodau
Regarding the 65.536 method limit issue this is what I have understood:
When you include a library, even if you only use a single method, the final file will also include the unused methods, so this will likely cause the limit to be exceeded.
Multidex may cause additional problems on older Android versions so if possible it is better to avoid it as FakeStore shouldn't be that big.

An alternative could be to enable minifyEnabled which will strip unused code, decreasing the number of methods and the final size.

@mar-v-in
What do you think about enabling minifyEnabled in FakeStore?

mar-v-in · 2024-01-23T12:35:03Z

I'm fine with using Proguard to remove unused methods or classes to reduce file size, however note that doing so imposes the risk to remove actually used methods. As soon as reflection is in place, proguard might be behaving wrong. So you need to take care of proper testing every functionality when activating it.

I don't like the renaming and obfuscation that comes with proguard / r8 minification. I'm pretty sure it can be turned off though. Renaming/obfuscation may add nondeterminism and generally makes it harder to link the resulting binary and it's behavior to the source code, which IMO is an important .

However, I also don't see any issue with using Multidex. I'm not aware of it causing issues in older versions as long as the androidx multidex support library is used correctly on SDK > 14, which is already our min sdk.

ale5000-git · 2024-01-23T12:48:10Z

Is there any use or need of reflection in FakeStore?

About renaming and obfuscation I agree.

The main issue with multidex on old Android versions is that some methods must be in the first dex and the developer must figure it himself otherwise it break without anyone noticing it (if it just break less used features).

mar-v-in · 2024-01-23T12:58:48Z

The main issue with multidex on old Android versions is that some methods must be in the first dex and the developer must figure it himself otherwise it break without anyone noticing it

This shouldn't happen a lot in practice. The app's Application class is loaded first and the build system tries to include it and all the code it uses in the primary classes.dex. The app's Application runs the multidex library code to load the other dex files.

There are two cases not covered by this:

A custom Application class that runs code via reflection (which might be undetected by the build system)
Third-party code loading the app's classes.dex without running the multidex loader.

The latter is what we've seen in practice causing issues in microG, partially because we don't correctly implement the dynamite loader (which should take care of loading the correct dex files as well). However third-parties are not supposed to load code from the vending package, so this shouldn't be relevant here.

ale5000-git · 2024-01-23T12:59:40Z

Instead of minifyEnabled to get minify without obfuscation we can use:

postprocessing {
    removeUnusedCode true
    removeUnusedResources true
    obfuscate false
    optimizeCode true
}

ale5000-git · 2024-01-23T13:05:41Z

@mar-v-in
There is a pull request that was abandoned but we may need it before or later: microg/FakeStore#35
I'm not sure if this load code from the vending package.

mar-v-in · 2024-01-23T13:43:12Z

removeUnusedResources would probably break things in play-services-core, but should be fine here.

The split install service is a service, which is part of the Application. Loading code directly is when the API does not use IPC, but loads and executes the code inside the third-party app itself. This happens for Maps SDK, security provider, cronet, Vision APIs and a few others that are loaded using dynamite.

ale5000-git · 2024-01-23T14:38:51Z

In addition to other advantages I think it will also improve performance if there is a single dex and it is small (expecially on 1GB devices where the memory is also slow).

If I'm not wrong beside install referrer, dummy in-app billing and this license code there is basically nothing in FakeStore so I suggest to enable this now (since currently it should be really easy to test regressions).

This reverts commit da7bb3d.

fynngodau · 2024-01-29T13:34:28Z

@ale5000-git Multidex is now disabled, and postprocessing as you suggested is now enabled.

ale5000-git · 2024-02-04T22:12:03Z

@fynngodau
I'm not sure why but on Windows building it with this command:
gradlew clean :vending-app:assembleDefaultRelease
will result in this error:
ERROR: C:\Users\MyUser\Documents\GmsCore\play-services-auth-api-phone\build\generated\aidl_source_output_dir\release\out\com\google\android\gms\auth\api\phone\internal\IAutofillPermissionStateCallback.java: Failed to GetFullPathName

fynngodau mentioned this pull request Oct 22, 2023

Licensing UI #2076

Merged

fynngodau added 12 commits December 19, 2023 09:47

Licensing service

4770884

Replace hardcoded auth token with auth token fetched via account

4485f34

Notify is user not signed in to any Google account

78c9404

Don't provide most negative results in V2 licensing

305d30e

Improve license notification icon & sound

a18c534

Query licenses from multiple Google accounts in a row

b88aace

Dismiss all notifications if user wants to sign in

ac265d8

Always request android.permission.GET_ACCOUNTS

141843f

Target JVM 1.8 instead of 17 in fakestore

884050c

Require permission to check license

a46daa3

Apply review

fff18c7

Reviewed-at: https://gitlab.e.foundation/e/os/GmsCore/-/merge_requests/91#note_458642

Check preference from within Licensing service

8934281

fynngodau force-pushed the licensing branch from ac42c13 to 8934281 Compare December 19, 2023 08:55

fynngodau added 2 commits January 11, 2024 22:56

Load device profile data for licensing user agent

4fe9bb9

Apply review

b65aaee

fynngodau added 2 commits January 11, 2024 23:12

Check preference from within Licensing service

30feaa2

Fix swapped docstrings

9fbaf2e

Fix Ignore on notification not working

224f822

fynngodau commented Jan 11, 2024

View reviewed changes

Enable multidex

da7bb3d

fynngodau force-pushed the licensing branch from 228491c to da7bb3d Compare January 11, 2024 22:55

fynngodau and others added 2 commits January 22, 2024 19:34

Check for POST_NOTIFICATIONS permission

92e38d1

Use big text style so that the text is displayed fully

46e8aac

Disable GetLocales lint

1632e54

Like f0b15d2

fynngodau added 2 commits January 29, 2024 13:40

Enable postprocessing in vending-app

d4f0b56

Revert "Enable multidex"

137a521

This reverts commit da7bb3d.

mar-v-in merged commit 62081a8 into microg:master Feb 16, 2024
1 check passed

fynngodau deleted the licensing branch February 16, 2024 21:14

ale5000-git mentioned this pull request Feb 19, 2024

Compiling the vending app now fails #2186

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Licensing service #2069

Implement Licensing service #2069

fynngodau commented Oct 4, 2023 •

edited

ale5000-git commented Oct 4, 2023

ale5000-git commented Oct 4, 2023

fynngodau commented Oct 4, 2023

mar-v-in commented Oct 4, 2023

fynngodau commented Oct 4, 2023

ale5000-git commented Oct 7, 2023

fynngodau commented Oct 12, 2023

fynngodau commented Oct 22, 2023

ale5000-git commented Dec 19, 2023

fynngodau commented Dec 19, 2023

ale5000-git commented Dec 19, 2023

ale5000-git commented Dec 19, 2023

ale5000-git commented Dec 21, 2023

ale5000-git commented Jan 8, 2024

fynngodau commented Jan 11, 2024

fynngodau Jan 11, 2024

fynngodau Jan 11, 2024

ale5000-git Jan 11, 2024 •

edited

fynngodau Jan 12, 2024 •

edited

ale5000-git Jan 12, 2024

fynngodau commented Jan 22, 2024

ale5000-git commented Jan 22, 2024

mar-v-in commented Jan 22, 2024

fynngodau commented Jan 22, 2024

ale5000-git commented Jan 23, 2024

mar-v-in commented Jan 23, 2024 •

edited

ale5000-git commented Jan 23, 2024

mar-v-in commented Jan 23, 2024

ale5000-git commented Jan 23, 2024

ale5000-git commented Jan 23, 2024

mar-v-in commented Jan 23, 2024

ale5000-git commented Jan 23, 2024 •

edited

fynngodau commented Jan 29, 2024

ale5000-git commented Feb 4, 2024

Implement Licensing service #2069

Implement Licensing service #2069

Conversation

fynngodau commented Oct 4, 2023 • edited

ale5000-git commented Oct 4, 2023

ale5000-git commented Oct 4, 2023

fynngodau commented Oct 4, 2023

mar-v-in commented Oct 4, 2023

fynngodau commented Oct 4, 2023

ale5000-git commented Oct 7, 2023

fynngodau commented Oct 12, 2023

fynngodau commented Oct 22, 2023

ale5000-git commented Dec 19, 2023

fynngodau commented Dec 19, 2023

ale5000-git commented Dec 19, 2023

ale5000-git commented Dec 19, 2023

ale5000-git commented Dec 21, 2023

ale5000-git commented Jan 8, 2024

fynngodau commented Jan 11, 2024

fynngodau Jan 11, 2024

Choose a reason for hiding this comment

fynngodau Jan 11, 2024

Choose a reason for hiding this comment

ale5000-git Jan 11, 2024 • edited

Choose a reason for hiding this comment

fynngodau Jan 12, 2024 • edited

Choose a reason for hiding this comment

ale5000-git Jan 12, 2024

Choose a reason for hiding this comment

fynngodau commented Jan 22, 2024

ale5000-git commented Jan 22, 2024

mar-v-in commented Jan 22, 2024

fynngodau commented Jan 22, 2024

ale5000-git commented Jan 23, 2024

mar-v-in commented Jan 23, 2024 • edited

ale5000-git commented Jan 23, 2024

mar-v-in commented Jan 23, 2024

ale5000-git commented Jan 23, 2024

ale5000-git commented Jan 23, 2024

mar-v-in commented Jan 23, 2024

ale5000-git commented Jan 23, 2024 • edited

fynngodau commented Jan 29, 2024

ale5000-git commented Feb 4, 2024

fynngodau commented Oct 4, 2023 •

edited

ale5000-git Jan 11, 2024 •

edited

fynngodau Jan 12, 2024 •

edited

mar-v-in commented Jan 23, 2024 •

edited

ale5000-git commented Jan 23, 2024 •

edited