Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account button and location picker button to microG settings, supersede #727, fix #413 #735

Closed
wants to merge 2 commits into from
Closed

Add account button and location picker button to microG settings, supersede #727, fix #413 #735

wants to merge 2 commits into from

Conversation

ale5000-git
Copy link
Member

@ale5000-git ale5000-git commented Mar 21, 2019

Add account button and location picker button to microG settings, supersede #727, fix #413

@Vavun


This change is Reviewable

…ersede #727, fix #413

Signed-off-by: ale5000 <ale5000-git@users.noreply.github.com>
@Nanolx
Copy link
Contributor

Nanolx commented Mar 21, 2019

working fine here; updated german translation accordingly, feel free to merge/cherry-pick: Nanolx@4f316e6

@ale5000-git
Copy link
Member Author

@mar-v-in: This PR is ready.

Can you please merge it?

@Vavun
Copy link
Contributor

Vavun commented Mar 22, 2019

@ale5000-git you should not be in such a hurry.
@Nanolx is working on better variant

Check latest commits on GmsCore and UnifiedNlp forks

@Nanolx
Copy link
Contributor

Nanolx commented Mar 23, 2019

@Vavun Technically you're working on it and I'm just mentoring/testing it. :)

I'll create a new branch with those changes isolated, the next days.

@ale5000-git
Copy link
Member Author

ale5000-git commented Mar 26, 2019

I have created the #741 for the account part, I will left the rest to you.

@ale5000-git ale5000-git deleted the add-google-account-and-location-test branch April 19, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add google account on alternative android implementation.
3 participants